fix broken NIX_PATH if paths contain spaces #879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtt9340
commented
Feb 21, 2024
Comment on lines
+6
to
+8
| # Similar to lib.escapeShellArg but escapes "s instead of 's, to allow for parameter expansion in shells | ||
| escapeDoubleQuote = arg: ''"${replaceStrings ["\""] ["\"\\\"\""] (toString arg)}"''; | ||
|
|
There was a problem hiding this comment.
I'm not sure if this would be the best place for a utility function like this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generated user activation script is broken when NIX_PATH contains paths with spaces in them due to the spaces not being escaped.
The motivation for this fix is that I've set
use-xdg-base-directoriestotruewhile also customizing theXDG_*_HOMEvariables to try and follow macOS conventions (i.e.XDG_CONFIG_HOMEis~/Library/Application Support, hence the issue with spaces in the path). I then set one of the paths innix.nixPathto$HOME/Library/Application Support/nix/defexpr/channelswhich causes the user activation script for switching to a new generation to break.