Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NSStatusItemSpacing and NSStatusItemSelectionPadding #872

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

robharrop
Copy link

Add NSStatusItemSpacing and NSStatusItemSelectionPadding to NSGlobalDomain options.

These options control the spacing between and padding inside status icons in the menu bar. With these options it's possible to squeeze more items on to menu bar, something that's especially useful on machines with a notch!

Copy link
Collaborator

@Enzime Enzime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you squash the two commits into one? It looks like they're exactly the same

default = null;
example = 12;
description = lib.mdDoc ''
Sets the spacing between status icons in the menu bar. The default is null.
Copy link
Collaborator

@Enzime Enzime Feb 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description should specify the macOS default like the rest of the options

system.defaults.NSGlobalDomain.AppleShowAllFiles = mkOption {
type = types.nullOr types.bool;
default = null;
description = lib.mdDoc ''
Whether to always show hidden files. The default is false.
'';
};

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are the MacOS defaults. Both of these options are unset by default.

@robharrop
Copy link
Author

Can you squash the two commits into one? It looks like they're exactly the same

Done. Apologies for the delay, I was travelling all last week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants