Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple tags with the same name in buildkite-agents.nix #817

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HeinrichApfelmus
Copy link

It turns out that the buildkite-agent supports multiple tags with the same name — for example, one Agent can be in multiple queue at the same time. This pull request adds support for this use case.

Example buildkite-agent.cfg

tags="queue=default,queue=mickey,system=x86_64-darwin"

Here, the name queue appears twice.

Desired syntax in .nix configuration:

{ queue = ["default" "mickey"]; system = "x86_64-darwin"; };

The code is a copy&paste from the corresponding NixOS buildkite-agent service.

@HeinrichApfelmus
Copy link
Author

HeinrichApfelmus commented Nov 23, 2023

The CI test test-stable (pull_request) fails with the error

/Users/runner/work/_temp/479957b6-fa59-4923-8891-5919bdfe1304.sh: line 1:  2063 Segmentation fault: 11  nix-build ./release.nix -I nixpkgs=channel:nixpkgs-23.05-darwin -I darwin=. -A tests

I do not know how to interpret this Segmentation fault.

@Enzime
Copy link
Collaborator

Enzime commented Nov 23, 2023

This error is unrelated to your PR, it's occurring on master atm and #819 should fix it 👍

@Enzime
Copy link
Collaborator

Enzime commented Nov 23, 2023

The PR has been merged, can you rebase your branch over master now, and see if the tests still fail?

@HeinrichApfelmus
Copy link
Author

The PR has been merged, can you rebase your branch over master now, and see if the tests still fail?

Done. All tests pass now. 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants