PLEASE DELETE - NOT READY / Release candidate v1.4 for Android Cordova v6.2.1 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 22 commits
March 14, 2017 13:58
build via CLI now works after fixing the project workspace settings added the local sdk libs into embedded binaries removed ContainerViewController.swift changes as breaking build - ToDo / expand callbacks to include verbose event data
added plugin for console.log but not seemingly working
debugging done via safari and simulator
fix to the button click event listener to correctly scope 'this' object within the callback and access the settings {}
buttonElement.addEventListener('click', this.lpStartMessagingConversation.bind(this), false);
successfully tested messaging conversation with hardcoded JWT for GA account
//ToDo//
Mirror support on Android
Support for configuration objects to be passed in and affect branding of SDK
iOS - fix embedded viewcontroller ContainerViewController showing previous VC when backing out of conversation -- why can we not use a single VC and have that as the delegate?
requires Android studio module import for the Messaging SDK libs to work also java 1.6 to 1.7 compliation fixes to build.gradle files for support of switch case on strings Android ------- current example runs in unauthenticated mode //ToDo// add token and call authenticated showConversation method variant implement reconnect callback on token expired using the bridge
successfully implemented branching of showConversation method depending on presence of token or not successfully tested using same JWT from webapp which retrieved conversation history from previous iOS messaging session as the sub claim ID matches the same customer -- as expected this is excellent results.
modified iOS classes to resolve issue #1 on view back navigation still android build issues with Cordova CLI -- installed Android Studio 2.4 preview to help and build/run the app from their
contains working sampleapps for both platforms supports authentication code input //todo// fix iOS custom VC consistent callback names and data config input updating UI/UX branding
includes v.2.1.1 iOS frameworks and libs app still runs NOT tested reconnect yet with expired JWT added it as a second plugin with clear folder name this also includes... authentication basic branding config POC callbacks using an iOS wrapper class Android class using iOS naming convention todo// fragment mode support on android? fullscreen custom window on android?
Added .bundle file to the Build Phases Setting : Copy Bundle Resources section App now builds having replaced frameworks with 2.1.1
uses PhoneGap Push Plugin and console plugin basics added as a starting point added project number from my GCM app //todo// update cordova plugin wrapper actions to support token in the init call Android/ register token using registerLPPusher - account,appID (package name) and token
able to switch between two distinct JWT tokens with unique sub claims after calling logout method and SDK init each time todo// achieve same results with iOS
Added support for logout method via new API action callback event names added for init sdk, set user profile and clearhistory/logout /plugin folder structure renamed and reordered for more consistency and version numbering
sampleapp03 added from scratch to test updated plugin code android platform 6.2.1 used for this sample app to resolve android SDK compatibility issues as per ionic-team/ionic-framework#10604 Callback handling changes ------------------------- api conversation calls for certain events like init,setuserprofile,start_conversation now return immediate plugin results and execute the requested js callbacks aysnc events now trigger as and when against the register single global context in the native code and in js iOS framework versions ----------- still pre v2.1.4...this will be added in next release to allow xcode update and swift update. Will be crucial for testing jwt refresh token bug
|
approved |
johnbeadle
changed the title
|
did not mean to pull request into main repo, was meant to merge into local branch master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v1.4 Release Candidate …
sampleapp03 added from scratch to test updated plugin code
android platform 6.2.1 used for this sample app to resolve android SDK compatibility issues as per ionic-team/ionic-framework#10604#issuecomment-293517292
Callback handling changes
api conversation calls for certain events like init,setuserprofile,start_conversation now return immediate plugin results and execute the requested js callbacks
aysnc events now trigger as and when against the register single global context in the native code and in js
iOS framework versions
still pre v2.1.4...this will be added in next release to allow xcode update and swift update. Will be crucial for testing jwt refresh token bug