Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dav #703

Merged
merged 19 commits into from
May 18, 2024
Merged

Improve dav #703

merged 19 commits into from
May 18, 2024

Conversation

MrGumpIT
Copy link
Contributor

  • handles the exception due to ` [ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: PathAccessException: Deletion failed, path = 'C:\Users\user\OneDrive\Documenti\Linwood\Butterfly\Remotes\Butterfly\Templates' (OS Error: The file could not be accessed. The file is being used by another process.
    , errno = 32)
    0 _checkForErrorResponse (dart:io/common.dart:55:9)
    1 _Directory._delete. (dart:io/directory_impl.dart:180:7)
    2 RemoteSystem.clearCachedContent (package:butterfly/api/file_system/file_system_remote.dart:149:7)
`
  • When you created a file without specifying its name or using Quick Launch, you would get a conflict, which led to the creation of multiple folders instead of the file

Copy link

vercel bot commented May 13, 2024

@MrGumpIT is attempting to deploy a commit to the Linwood Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@CodeDoctorDE CodeDoctorDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this pr, I really like your changes, I just have some adjustments i would make

app/lib/api/file_system/file_system_dav.dart Outdated Show resolved Hide resolved
app/lib/api/file_system/file_system_dav.dart Outdated Show resolved Hide resolved
app/lib/api/file_system/file_system_remote.dart Outdated Show resolved Hide resolved
app/lib/api/file_system/file_system_remote.dart Outdated Show resolved Hide resolved
app/lib/api/file_system/file_system_remote.dart Outdated Show resolved Hide resolved
Copy link
Member

@CodeDoctorDE CodeDoctorDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your hard work, I reviewed your code, feel free to comment on these if you disagree

app/lib/api/file_system/file_system_remote.dart Outdated Show resolved Hide resolved
app/lib/api/file_system/file_system_remote.dart Outdated Show resolved Hide resolved
app/lib/api/file_system/file_system_remote.dart Outdated Show resolved Hide resolved
app/lib/api/file_system/file_system_dav.dart Outdated Show resolved Hide resolved
Copy link

vercel bot commented May 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
butterfly ✅ Ready (Inspect) Visit Preview May 17, 2024 9:24pm

app/lib/api/file_system/file_system_dav.dart Outdated Show resolved Hide resolved
app/lib/api/file_system/file_system_dav.dart Outdated Show resolved Hide resolved
Copy link
Member

@CodeDoctorDE CodeDoctorDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, will merge it tomorrow!

@MrGumpIT
Copy link
Contributor Author

thanks, I will try to implement p. subsequently

@CodeDoctorDE CodeDoctorDE merged commit 12103e0 into LinwoodDev:develop May 18, 2024
14 checks passed
@CodeDoctorDE
Copy link
Member

thanks for contributing!

@MrGumpIT MrGumpIT deleted the improveDav branch May 18, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants