Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched to GFM Markdown flavour to allow rendering checkboxes #108

Open
wants to merge 46 commits into
base: main
Choose a base branch
from

Conversation

reactorcoremeltdown
Copy link
Contributor

Summary

In GFM one can use [ ] and [x] in lists to draw checkboxes. That helps to track progress in some documents (not intending to use Wikmd as a task tracker, but that may be useful to display status of things, and it's much quicker to type than strikethrough)

image

Details

Adding this feature involved two things:

  • Changing markup to gfm in Pandoc
  • Excluding form elements from html Cleaner

Please feel free to reject the PR if any of my changes violate the design.

Checks

  • In case of new feature, add short overview in docs/<corresponding file>
  • Tested changes

@Linbreux
Copy link
Owner

Linbreux commented Mar 6, 2023

hi @reactorcoremeltdown
That maybe a nice feature, everything seems to work, except that the latex output is not correct anymore...

image

@reactorcoremeltdown
Copy link
Contributor Author

hi @reactorcoremeltdown That maybe a nice feature, everything seems to work, except that the latex output is not correct anymore...

image

May I ask you for source LaTeX expression, so I could test the feature thoroughly?

@Linbreux
Copy link
Owner

You can find it in the "how to use the wiki" file. It should be in your wikmd repo :)

@reactorcoremeltdown
Copy link
Contributor Author

reactorcoremeltdown commented Mar 27, 2023

Screenshot_20230327-113151-300

Does that look better? (Seems like not filtering out form elements is enough for rendering checkboxes)

@reactorcoremeltdown
Copy link
Contributor Author

@Linbreux requesting a review here.

Please let me know if something looks odd!

@Linbreux
Copy link
Owner

It would be nice to have. Although I don't get any checkbox...
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants