Fixed issue #19550: Calling get_class() without arguments is deprecated PHP8.3 #3839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
note: there is still relevant get_class() without arguments in vendor/pear/pear-core-minimal |
gabrieljenik
approved these changes
May 3, 2024
There was a problem hiding this comment.
Code looks OK.
Still a few remarks:
- Should the PR go to DEV or master?
- @olleharstedt I added you as reviewer as there are changes to the automatic tests.
|
I wouldn't merge it until getting another revision |
Shnoulle
reviewed
May 15, 2024
| @@ -14,7 +14,7 @@ protected static function initialize() | |||
| if (static::$initialized) return; | |||
| static::$initialized = true; | |||
| static::$parentPath = __FILE__; | |||
| for ($i=substr_count(get_class(), (string) static::$nsChar);$i>=0;$i--) { | |||
| for ($i=substr_count(get_class(new static), (string) static::$nsChar);$i>=0;$i--) { | |||
There was a problem hiding this comment.
Arg !
RobThree/TwoFactorAuth@225216a
:)
Shnoulle
approved these changes
May 15, 2024
Send it in testing ? We need PHP8.3 in some month. Some forum post already send with PHP8.3 issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LimeSurvey manual says v6 php requirement is LS 6.x from PHP 7.4.x to 8.x
LS master should not use mehods deprecated by the latest php 8 (8.3) also the tests should run the 8.3 instead of 8.2.
This fix replaces all get_class() without arguments that will throw an error in php 8.3 with get_class() WITH relevant argument $this or
new staticin static context to avoid errors in php 8.3also I changed the php 8.2=>8.3 in ci tests matrix that without this fix would be red, but are green with this fix.