This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
remove sheet db #210
Open
remove sheet db #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aniketmaurya
requested review from
kaushikb11,
pritamsoni-hsr and
rohitgr7
as code owners
aniketmaurya
commented
Oct 16, 2022
| @@ -62,12 +52,6 @@ def handle_command(self): | |||
| msg = f":zap: Generating image for prompt: _{prompt}_ :zap:. (This public version of the app may run slow. Clone and run the app on your own Lightning AI account to enable the creation of your own Slackbot with customizable performance)" # noqa: E501 | |||
| return msg, 200 | |||
|
|
|||
| def save_new_workspace(self, team_id, bot_token): | |||
There was a problem hiding this comment.
it will be handled by the Bot component
aniketmaurya
commented
Oct 16, 2022
| @@ -37,23 +37,13 @@ def __init__( | |||
| self._secrets_drive: Drive = None | |||
| self._server: uvicorn.Server = None | |||
|
|
|||
| self._SHEET_API_URL = os.environ.get("SHEET_API_URL") | |||
|
|
|||
| def _get_bot_token(self, team_id): | |||
There was a problem hiding this comment.
bot component exposes get_bot_token_by_team_id for this
Borda
approved these changes
Oct 27, 2022
|
@aniketmaurya can we also finish this one or close it? 🐿️ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
The Sheet DB has a limit of 5K hits in a month. Let's remove that and use a local DB persisted with Drive.
What does this PR do?
Fixes # (issue).
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃