(6/n) Support 2D Parallelism - Trainer example #19879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
force-pushed
the
feature/tp-pl-strategy-example
branch
from
92c6d16
to
d81249b
Compare
justusschock
approved these changes
May 17, 2024
lantiga
reviewed
May 17, 2024
awaelchli
force-pushed
the
feature/tp-pl-strategy-example
branch
from
82a417f
to
23a6848
Compare
⚡ Required checks status: All passing 🟢Groups summary🟢 lightning_fabric: Azure GPU
These checks are required after the changes to Thank you for your contribution! 💜
|
carmocca
reviewed
May 20, 2024
| inputs = batch[:, :-1] | ||
| labels = batch[:, 1:] | ||
| output = self.model(inputs) | ||
| with loss_parallel(): |
There was a problem hiding this comment.
TIL. Are you also enabling this for backward? https://github.com/pytorch/pytorch/blob/5fb11cda4fe60c1a7b30e6c844f84ce8933ef953/torch/distributed/tensor/parallel/loss.py#L35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds an example for 2D parallelism (Tensor Parallelism + FSDP2) for the Trainer. It is equivalent to the one for Fabric added in #19846, so the model code etc. is copy-pasted. The main file to review is
examples/pytorch/tensor_parallel/train.py.This PR depends on #19878
📚 Documentation preview 📚: https://pytorch-lightning--19879.org.readthedocs.build/en/19879/
cc @Borda @carmocca @justusschock @awaelchli