This repository has been archived by the owner on Oct 21, 2022. It is now read-only.
The commits from previous PR have been isolated and additionally, electron and cljs have been slightly bumped #2430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit c2f590c)
(cherry picked from commit 3e63cc7)
(cherry picked from commit 5f6a041)
(cherry picked from commit b5b1e85)
(cherry picked from commit 0b7607f)
(cherry picked from commit 00cd192)
(cherry picked from commit 6f717d5)
(cherry picked from commit e80ae29)
(cherry picked from commit 85bc3fd)
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| @@ -101,7 +101,7 @@ | |||
| meta["no-inspect"] = true; | |||
| var final = safeStringify(exp); | |||
| } | |||
| ipc.sendToHost("browser-raise", [meta.obj, meta.ev, {result: final, meta: meta}]); | |||
| ipcRenderer.sendToHost("browser-raise", [meta.obj, meta.ev, {result: final, meta: meta}]); | |||
deploy/core/main.js
Outdated
| @@ -101,7 +101,7 @@ function parseArgs() { | |||
| optimist.showHelp(); | |||
| process.exit(0); | |||
| } | |||
| } | |||
| }; | |||
| @@ -49,7 +49,7 @@ function createWindow() { | |||
| }); | |||
|
|
|||
| // and load the index.html of the app. | |||
| window.loadUrl('file://' + __dirname + '/LightTable.html?id=' + window.id); | |||
| window.loadURL('file://' + __dirname + '/LightTable.html?id=' + window.id); | |||
| ipc = require("ipc"), | ||
| var app = require('electron').app, // Module to control application life. | ||
| BrowserWindow = require('electron').BrowserWindow, // Module to create native browser window. | ||
| ipcMain = require("electron").ipcMain, |
| BrowserWindow = require('browser-window'), // Module to create native browser window. | ||
| ipc = require("ipc"), | ||
| var app = require('electron').app, // Module to control application life. | ||
| BrowserWindow = require('electron').BrowserWindow, // Module to create native browser window. |
| var app = require('app'), // Module to control application life. | ||
| BrowserWindow = require('browser-window'), // Module to create native browser window. | ||
| ipc = require("ipc"), | ||
| var app = require('electron').app, // Module to control application life. |
|
Additionally, Hound issues have been overlooked. Must fix it this time. |
|
Hmmm, maybe fix optimist and request(new issue) on this same PR. |
|
Concerning the Hound issues, check my comments on #2416. |
|
Sure. 🍺 |
…ll works Signed-off-by: Pratik Karki <predatoramigo@gmail.com>
Signed-off-by: Pratik Karki <predatoramigo@gmail.com>
prertik
force-pushed
the
electron-update
branch
from
7dbf895
to
fe8767c
Compare
Codecov Report
@@ Coverage Diff @@
## develop #2430 +/- ##
========================================
Coverage 16.66% 16.66%
========================================
Files 1 1
Lines 60 60
Branches 6 6
========================================
Hits 10 10
Misses 44 44
Partials 6 6Continue to review full report at Codecov.
|
Signed-off-by: Pratik Karki <predatoramigo@gmail.com>
Signed-off-by: Pratik Karki <predatoramigo@gmail.com>
Replace optimist with yargs
|
Needs further investigation with yargs. Maybe it needs to use older version. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some bugs with Electron UI handling. Needs further investigation before merging.