This repository has been archived by the owner on Oct 21, 2022. It is now read-only.
WIP: needs commit splitting #2419
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pratik Karki <predatoramigo@gmail.com>
Signed-off-by: Pratik Karki <predatoramigo@gmail.com>
Update electron and Clojurescript
Signed-off-by: Pratik Karki <predatoramigo@gmail.com>
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| from: CodeMirror.Pos(cur.line, token.start), | ||
| to: CodeMirror.Pos(cur.line, token.end) | ||
| }; | ||
| if (found.length) return {list: found, from: from, to: to}; |
| var found = []; | ||
| for (var i = 0; i < options.words.length; i++) { | ||
| var word = options.words[i]; | ||
| if (word.slice(0, token.string.length) == token.string) | ||
| if (word.slice(0, term.length) == term) |
| if (token.string && /\w/.test(token.string[token.string.length - 1])) { | ||
| var term = token.string, from = CodeMirror.Pos(cur.line, token.start); | ||
| } else { | ||
| var term = "", from = to; |
There was a problem hiding this comment.
'from' is already defined.
'term' is already defined.
| return CodeMirror.hint.anyword(cm, options); | ||
| return function(cm, options) { return CodeMirror.hint.anyword(cm, options) } | ||
| } else { | ||
| return function() {} |
| } else if (CodeMirror.hint.anyword) { | ||
| return CodeMirror.hint.anyword(cm, options); | ||
| return function(cm, options) { return CodeMirror.hint.anyword(cm, options) } |
| resolved.async = true | ||
| } else { | ||
| resolved = function(cm, options) { | ||
| var app = applicableHelpers(cm, helpers) |
| } | ||
| run(0) | ||
| } | ||
| resolved.async = true |
| } | ||
| } | ||
| run(0) | ||
| } |
| else run(i + 1) | ||
| } | ||
| } | ||
| run(0) |
| } else { | ||
| var result = helper(cm, options) | ||
| if (result) callback(result) | ||
| else run(i + 1) |
|
Hound's review should be ignored here as the CM addons are pulled from |
|
This pull request introduces 2 alerts when merging 88a7445 into 6a4f68b - view on LGTM.com new alerts:
Comment posted by LGTM.com |
Signed-off-by: Pratik Karki <predatoramigo@gmail.com>
| }, options) | ||
| } else { | ||
| var result = helper(cm, options) | ||
| if (result) callback(result) |
| else run(i + 1) | ||
| }, options) | ||
| } else { | ||
| var result = helper(cm, options) |
There was a problem hiding this comment.
'result' is already defined.
Missing semicolon.
| helper(cm, function(result) { | ||
| if (result) callback(result) | ||
| else run(i + 1) | ||
| }, options) |
| if (helper.async) { | ||
| helper(cm, function(result) { | ||
| if (result) callback(result) | ||
| else run(i + 1) |
| var helper = app[i] | ||
| if (helper.async) { | ||
| helper(cm, function(result) { | ||
| if (result) callback(result) |
| var result = [] | ||
| for (var i = 0; i < helpers.length; i++) | ||
| if (helpers[i].supportsSelection) result.push(helpers[i]) | ||
| return result |
| if (!cm.somethingSelected()) return helpers | ||
| var result = [] | ||
| for (var i = 0; i < helpers.length; i++) | ||
| if (helpers[i].supportsSelection) result.push(helpers[i]) |
| var helpers = cm.getHelpers(cm.getCursor(), "hint"), words; | ||
| function applicableHelpers(cm, helpers) { | ||
| if (!cm.somethingSelected()) return helpers | ||
| var result = [] |
| CodeMirror.registerHelper("hint", "auto", function(cm, options) { | ||
| var helpers = cm.getHelpers(cm.getCursor(), "hint"), words; | ||
| function applicableHelpers(cm, helpers) { | ||
| if (!cm.somethingSelected()) return helpers |
| if (editor[prop] !== undefined) out[prop] = editor[prop]; | ||
| if (options) for (var prop in options) | ||
| if (options[prop] !== undefined) out[prop] = options[prop]; | ||
| if (out.hint.resolve) out.hint = out.hint.resolve(cm, pos) |
|
This pull request introduces 2 alerts when merging 231602d into 6a4f68b - view on LGTM.com new alerts:
Comment posted by LGTM.com |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in nascent condition and will be susceptible to a lot of changes.
This PR can even be pointless.