Skip to content
This repository has been archived by the owner on Oct 21, 2022. It is now read-only.

Remove set-width-final! see #2038 #2147

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove set-width-final! see #2038 #2147

wants to merge 1 commit into from

Conversation

geusebi
Copy link

@geusebi geusebi commented Feb 22, 2016

This fix seems to solve #2038 but I actually don't know why or how it looks to fix it :)
It needs testing before being considered for a merge.

@cldwalker cldwalker added this to the 0.8.2 milestone Oct 9, 2016
@sbauer322
Copy link
Contributor

This fix seems to address the issue and I have not found any problems introduced by removing the code.

@cldwalker, @rundis - any interest in testing this out as well, or are we clear to merge?

@cldwalker
Copy link
Member

@sbauer322 Before removing a behavior as a fix, it'd be good to dig in and understand what the behavior is providing and for what cases it works and doesn't work (I haven't written this and don't have context). If we are unable to fix it, we should determine if removing it from the codebase will have a negative effect on some users. If it will, then an alternative could be to have not it enabled by default e.g. removing

[:tabset :lt.objs.tabs/set-width-final!]
. Kenny digged into this some at #2038 (comment)

@sbauer322
Copy link
Contributor

sbauer322 commented Nov 3, 2016

we should determine if removing it from the codebase will have a negative effect on some users

@cldwalker - could you elaborate on how we would go about testing this with users?

@cldwalker
Copy link
Member

@cldwalker - could you elaborate on how we would go about testing this with users?

I'm not suggesting testing this w/ users but rather confirming that this works locally for the different scenarios mentioned in #2038 - different # of monitors and possibly on different platforms

@sbauer322
Copy link
Contributor

Thanks for clarifying!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants