Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Alias search #875

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

RFC: Alias search #875

wants to merge 2 commits into from

Conversation

ta264
Copy link
Contributor

@ta264 ta264 commented Jul 31, 2019

Database Migration

NO

Description

Hooks up artist / album alias for indexer search and result parsing. So far only in place for newznab.

Currently it looks for a "best" query by looking through titles/aliases for one that contains no unicode or special characters. If one isn't found, it takes the main title. Results are fetched in tiers until we get a result (so if the main query returns results it doesn't search with any aliases).

Todos

  • Tests

Issues Fixed or Closed by this PR

@ta264 ta264 requested a review from Qstick July 31, 2019 18:56
@ta264 ta264 added this to the v0.8.0 milestone Aug 2, 2019
@Qstick
Copy link
Contributor

Qstick commented Aug 25, 2019

@ta264 do we need to pull the fix commit from this into 0.7?

@ta264
Copy link
Contributor Author

ta264 commented Aug 25, 2019

Yeah we probably do. I was also wondering about pulling in the change to pull aliases into the dB at least for parsing, even if we save the alias search for 0.8

@ta264
Copy link
Contributor Author

ta264 commented Aug 25, 2019

Actually we pulled the fix commit across in #879

@Qstick Qstick modified the milestones: v0.8.0, v1.0.0 Jan 19, 2021
@bakerboy448 bakerboy448 added conflict conflict - cannot merge, needs resolution Area: Database Issue is related to the database Area: Db-migration labels Oct 2, 2021
@bakerboy448 bakerboy448 added the Status: Waiting for OP Action Required from OP label Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Database Issue is related to the database conflict conflict - cannot merge, needs resolution Status: Waiting for OP Action Required from OP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants