Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to net8.0 #4767

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from
Draft

Bump to net8.0 #4767

wants to merge 5 commits into from

Conversation

Gauvino
Copy link

@Gauvino Gauvino commented Apr 21, 2024

Description

Overall update to .NET 8, need further testing and building test to see if everything working well.

Todos

@github-actions github-actions bot added Area: UI Issue is related to UI, should also add the issue to the new UI project, if it isn't a bug. Area: API Issue is related to the API labels Apr 21, 2024
 - Update .NET to 8.0
 - Update .NETFramework to 4.8.1
 - Update packages versions
 - Update MacOS to 12 since earlier version or not supported :
   https://github.com/dotnet/core/blob/main/release-notes/8.0/supported-os.md
 - Remove clock and change add to append
 - OS-release update to Ubuntu 20.04
 - Fix task: NodeTool@0 to UseNode@1
 - Fix task: reportgenerator@4 to reportgenerator@5
@Gauvino Gauvino changed the title Update to .NET 8 Bump to .net8.0 Apr 21, 2024
@Gauvino Gauvino changed the title Bump to .net8.0 Bump to net8.0 Apr 21, 2024
@mynameisbogdan
Copy link
Collaborator

You'll need to fix the code and tests for every major version bump for the packages like Sentry, System.IO.Abstractions.TestingHelpers, etc.

@Gauvino
Copy link
Author

Gauvino commented Apr 21, 2024

You'll need to fix the code and tests for every major version bump for the packages like Sentry, System.IO.Abstractions.TestingHelpers, etc.

I can't build at all cause there is too many warnings in error in the console if I can, I'll fix everything, but there is so many

@Gauvino Gauvino marked this pull request as draft April 21, 2024 15:06
@mynameisbogdan
Copy link
Collaborator

I pretty much know. 😀

Tried months ago myself to bump System.IO.Abstractions and gave up because I didn't had the time to deal with fixing every broken test.

@Gauvino
Copy link
Author

Gauvino commented Apr 21, 2024

I pretty much know. 😀

Tried months ago myself to bump System.IO.Abstractions and gave up because I didn't had the time to deal with fixing every broken test.

And doing so on every arr would be a week work at this point 😅

@mynameisbogdan
Copy link
Collaborator

Only Lidarr and Readarr uses System.IO.Abstractions, but still remains Sentry and others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: API Issue is related to the API Area: UI Issue is related to UI, should also add the issue to the new UI project, if it isn't a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants