Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal for documenting fields and files #518

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ouabache
Copy link

initial proposal

@ubruhin
Copy link
Member

ubruhin commented Oct 5, 2019

Thanks for working on this 😃

My thoughts so far:

  • I would move the basic S-Expressions documentation (general structure, charset, EOL character, formatting, ...) into a separate page (e.g. called "File Format") since it's not specific to libraries. Or even move everything into this new page, so all *.lp files are documented in one page to avoid clutter up basic documentation of libraries and projects.
  • There are a lot of empty lines - please only use 1 empty line to separate paragraphs and 2 empty lines to separate chapters.
  • I don't really understand the right column of the file format documentation 😉 What are the LP_* terms used for?
  • I have not much experience with documenting file formats, but maybe it would make sense to use something like BNF for that? @dbrgn @rnestler, any opinion about that?

@ubruhin ubruhin added documentation file format Issues affecting the file format labels Oct 5, 2019
@dbrgn
Copy link
Member

dbrgn commented Oct 5, 2019

BNF (or EBNF) would work, but since we don't actually parse the file format spec, we don't benefit that much from a structured format. On the other hand, the BNF would give us re-usable types, so a (pos x y) type only needs to be defined once and can then be re-used.

@rnestler what do you think?

@ouabache
Copy link
Author

ouabache commented Oct 5, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation file format Issues affecting the file format
Development

Successfully merging this pull request may close these issues.

None yet

3 participants