New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proposal for documenting fields and files #518
Open
ouabache
wants to merge
2
commits into
LibrePCB:master
Choose a base branch
from
ouabache:file_format
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for working on this 😃 My thoughts so far:
|
The right column was my attempt to cover all the use cases:
1) A field must be defined only one time
2) A field must be defined but can have more than one definition
3) A field may be defined zero or one time only
4) A field may be defined zero or multiple times.
The LP_ names are simply to have a name that you can refer to for that
field from the documentation
I don't have a lot of experience with file formats either. If I see an
example then I can understand it easier than trying
to parse some formal definition.
I also put in a pull request for 10 bga packages for the LibrePCB_Base
library.
…On Sat, Oct 5, 2019 at 4:34 AM U. Bruhin ***@***.***> wrote:
Thanks for working on this 😃
My thoughts so far:
- I would move the basic S-Expressions documentation (general
structure, charset, EOL character, formatting, ...) into a separate page
(e.g. called "File Format") since it's not specific to libraries. Or even
move everything into this new page, so all *.lp files are documented in one
page to avoid clutter up basic documentation of libraries and projects.
- There are a lot of empty lines - please only use 1 empty line to
separate paragraphs and 2 empty lines to separate chapters.
- I don't really understand the right column of the file format
documentation 😉 What are the LP_* terms used for?
- I have not much experience with documenting file formats, but maybe
it would make sense to use something like BNF
<https://en.wikipedia.org/wiki/Backus%E2%80%93Naur_form> for that?
@dbrgn <https://github.com/dbrgn> @rnestler
<https://github.com/rnestler>, any opinion about that?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#518?email_source=notifications&email_token=AAKX3XEGHOHDPINHL26K2KLQNB3VJA5CNFSM4IXXGQ3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEANQMPA#issuecomment-538641980>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAKX3XFU36342FLMEHM2HUDQNB3VJANCNFSM4IXXGQ3A>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initial proposal