Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Icon8 icons #1336

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

FedericoCeratto
Copy link
Contributor

@FedericoCeratto FedericoCeratto commented Mar 20, 2024

The following icons are from https://icons.getbootstrap.com/ under MIT license:
img/actions/export.png
img/actions/import.png
img/actions/view_3d.png
img/library/part.png
img/actions/move_to.png

The following are made by me with parts from the bootstrap collection, under MIT license:
img/actions/clone.png
img/actions/export_pick_place_file.png
img/actions/flip_horizontal.png
img/actions/flip_vertical.png
img/actions/ruler.png
img/actions/drc.png
img/actions/export_pixmap.png
img/actions/order_pcb.png

@FedericoCeratto FedericoCeratto marked this pull request as ready for review March 21, 2024 09:23
@ubruhin
Copy link
Member

ubruhin commented Mar 22, 2024

Hmm I appreciate your work, but to be honest I'm not confident with some of these icons 🙈

The only one I totally agree with is export_pick_place_file.png, it is even more precise than the old icon.

For clone.png and export_pixmap.png IMHO they are not descriptive enough. The clone icon looks like a normal "copy" operation, but cloning means something different than copying. And for the pixmap it is important to express pixel format (like photos, thus the old icon), but just a schematic does not imply any image format.

The ruler.png looks not bad, but in the toolbar it's simply too small, the ticks are almost not visible.

And all the monochrome icons (although some look really nice) have two problems: They are not readable on dark themes (could be fixed by also providing a white variant) and they make the UI even more inconsistent. To me, the toolbars look really ugly with this mix of different icon styles:

image

Note that for long term I'm even considering using monochrome-only icons since (in white) they work very well on dark themes. But for short-term I really want to use colored icons to keep the look more or less consistent.

@FedericoCeratto
Copy link
Contributor Author

@ubruhin based on the conversation on Telegram I understood you seemed happy to consider Bootstrap and I starting converting all icons and drawing new ones in SVG and PNG. Please let me know if I should stop or continue :)
Regarding the readability, AFAIK monochrome icons are used because they can be flipped to negative at runtime as needed and also painted with any hue to make applications "themed".

@ubruhin
Copy link
Member

ubruhin commented Mar 22, 2024

Hmm yes I am happy considering Bootstrap icons, but I thought this PR is only about getting rid of Icons8 icons because of their license 🤔 Changing all icons though is a much bigger task, probably taking a long time to get finished (also with some uncertainty whether we really like monochrome icons or not, this needs to be tested).

Also inverting colors at runtime is an additional task which would need to be implemented and tested (I already did a quick test some time ago, but it was way too CPU intensive so I decided to use separate PNGs for dark and light themes). SVG is another topic which needs to be investigated (performance?).

So I'd like to do this step by step, beginning with clarifying licenses (#1316), then getting rid of icons8 (this PR) and for long-term monochrome icons (maybe together with a dark-only LibrePCB theme, then we even don't need black icons).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants