New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Icon8 icons #1336
base: master
Are you sure you want to change the base?
Replace Icon8 icons #1336
Conversation
Hmm I appreciate your work, but to be honest I'm not confident with some of these icons 🙈 The only one I totally agree with is For The And all the monochrome icons (although some look really nice) have two problems: They are not readable on dark themes (could be fixed by also providing a white variant) and they make the UI even more inconsistent. To me, the toolbars look really ugly with this mix of different icon styles: Note that for long term I'm even considering using monochrome-only icons since (in white) they work very well on dark themes. But for short-term I really want to use colored icons to keep the look more or less consistent. |
@ubruhin based on the conversation on Telegram I understood you seemed happy to consider Bootstrap and I starting converting all icons and drawing new ones in SVG and PNG. Please let me know if I should stop or continue :) |
Hmm yes I am happy considering Bootstrap icons, but I thought this PR is only about getting rid of Icons8 icons because of their license 🤔 Changing all icons though is a much bigger task, probably taking a long time to get finished (also with some uncertainty whether we really like monochrome icons or not, this needs to be tested). Also inverting colors at runtime is an additional task which would need to be implemented and tested (I already did a quick test some time ago, but it was way too CPU intensive so I decided to use separate PNGs for dark and light themes). SVG is another topic which needs to be investigated (performance?). So I'd like to do this step by step, beginning with clarifying licenses (#1316), then getting rid of icons8 (this PR) and for long-term monochrome icons (maybe together with a dark-only LibrePCB theme, then we even don't need black icons). |
The following icons are from https://icons.getbootstrap.com/ under MIT license:
img/actions/export.png
img/actions/import.png
img/actions/view_3d.png
img/library/part.png
img/actions/move_to.png
The following are made by me with parts from the bootstrap collection, under MIT license:
img/actions/clone.png
img/actions/export_pick_place_file.png
img/actions/flip_horizontal.png
img/actions/flip_vertical.png
img/actions/ruler.png
img/actions/drc.png
img/actions/export_pixmap.png
img/actions/order_pcb.png