scroll guides menu independently #174
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swantzter
reviewed
Sep 28, 2021
| @@ -328,6 +330,10 @@ header nav details a { | |||
| border-block-end: 1px solid var(--c-border); | |||
| padding: 1rem; | |||
| } | |||
|
|
|||
| main { | |||
| overflow-y: scroll; | |||
There was a problem hiding this comment.
I'd prefer auto, scroll will always render the scroll bar even if it's not needed
| @@ -2,12 +2,12 @@ | |||
| <html lang="en"> | |||
| {%- include head.html with_hero=true -%} | |||
|
|
|||
| <body> | |||
| <body style="overflow-y: scroll;"> | |||
There was a problem hiding this comment.
style="" really shouldn't be used, put it in the appropriate <style> tag
| @@ -379,6 +385,10 @@ footer div a:not([rel*=license]), footer div .copyright { | |||
| } | |||
|
|
|||
| @media screen and (min-width: 800px) { | |||
| footer { | |||
| position: sticky; | |||
There was a problem hiding this comment.
using position: sticky without an inset (top/bottom/left/right) feels odd, it's got no place to stick to. what's the desired effect?
| @@ -142,6 +143,7 @@ main :is(h2, h3, h4, h5, h6) a:hover::before { | |||
|
|
|||
| @media screen and (min-width: 800px) { | |||
| body { | |||
| overflow-y: hidden; | |||
There was a problem hiding this comment.
this feels like a bad idea, why hide it?
| @@ -76,8 +76,9 @@ main *, .hero * { | |||
|
|
|||
| body { | |||
| background-color: var(--c-bg); | |||
| min-height: 100vh; | |||
| height: 100vh; | |||
There was a problem hiding this comment.
feels like this will have the effect that the footer will always be on screen? instead of being off screen on long pages?
benharri
force-pushed
the
aside-scroll-independently
branch
from
77223bd
to
95804f8
Compare
swantzter
added
Area: General
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this feel kinda janky, let me know if you can think of a better way to do this
closes #39