Add module to reject spurious certificate fingerprints #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronmdjones
force-pushed
the
amdj/rejectnonsha512certfp
branch
from
0fa669e
to
cc4f7e8
Compare
It's quite common that people add fingerprints with the wrong digest algorithm, and rarer but not unheard of for people to add complete garbage (services doesn't care about the format). This module checks for 128 hexadecimal characters; rejecting everything else with an explanatory error message to that effect.
aaronmdjones
force-pushed
the
amdj/rejectnonsha512certfp
branch
from
cc4f7e8
to
b01b1af
Compare
glguy
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's quite common that people add fingerprints with the wrong digest algorithm, and rarer but not unheard of for people to add complete garbage (services doesn't care about the format).
This module checks for 128 hexadecimal characters; rejecting everything else with an explanatory error message to that effect.