New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Date is no longer an empty object #437

Open

allonzy wants to merge 4 commits into Leonidas-from-XIV:master from allonzy:allonzy-patch-1

allonzy commented Mar 21, 2018

The isEmpty function consider a date as empty object, but it is not, so i fixed that by adding a instanceof Date in the isEmpty function

allonzy added 4 commits

March 21, 2018 12:41


          Update parser.js

5c86e31


          Update parser.coffee

7c87cb0


          Update parser.js

196b31a


          Update parser.coffee

19b7d4b

Owner

Leonidas-from-XIV commented Mar 22, 2018

It looks like you did the patches manually. To ensure they last, you should edit the CoffeeScript code and then run the compiler.

Also, it looks like your patches broke the rather extensive unit tests, so there seems to be something wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment