Testing and minor fix for federation with Discourse #4628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nutomic
force-pushed
the
discourse-federation
branch
2 times, most recently
from
4b0038a
to
583add8
Compare
Nutomic
force-pushed
the
discourse-federation
branch
from
583add8
to
b277ea9
Compare
Note that this behaviour is configurable. It's default is a 500 char limit because that is the Mastodon default. See further |
dessalines
approved these changes
Apr 16, 2024
Nutomic
requested review from
phiresky,
dullbananas and
SleeplessOne1917
as code owners
Nutomic
force-pushed
the
discourse-federation
branch
from
19f9a62
to
0af99ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some federation objects from Discourse to our tests to ensure that they get parsed successfully. Only a minor change was necessary. Its still possible that there are other things which are incompatible.
Notably Discourse doesnt federate the full content of posts but only the first x characters. I consider this completely broken, because its impossible for Lemmy to retrieve the full post content and it doesnt make sense having to visit an external site. If certain implementations like Mastodon only want to show a limited amount of text, they can do that on the receiving side.
See https://meta.discourse.org/t/federation-support-for-discourse/90921/87