Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor post view #4042

Closed
wants to merge 163 commits into from
Closed

Refactor post view #4042

wants to merge 163 commits into from

Conversation

dullbananas
Copy link
Collaborator

@dullbananas dullbananas commented Oct 13, 2023 •
edited

Later this will be done for all views

Other changes in this PR:

  • Made more subqueries deduplicated because that can now be done very cleanly using filter_var_eq
  • Read less data in top community prefetch
  • When no local user is logged in, enabling options like saved_only now returns no posts instead of ignoring the option

@dullbananas
ReadOrList trait
b666e17
@dullbananas
run_query, utils::expect_1_row
9ffd0c6
@dullbananas
refactor selections
57a7794
@dullbananas
removed boxed expressions
d6da4ee
@dullbananas
remove person_id_join and local_user_id_join
3648ed4
@dullbananas
move some things out of else block
cddf0a7
@dullbananas
remove more things from else block
5423a95
@dullbananas
remove and
11d98b8
@dullbananas
clean up listing_type filter
39fc3ef
@dullbananas
remove eq(true), eq(false)
cce2029
@dullbananas
stuff
28e36c6
@dullbananas
unify more filters
29e39b9
@dullbananas
not_deleted
51c890e
@dullbananas
only apply language filter if logged in
2734861
@dullbananas
refactor block filter
f59e9b4
@dullbananas
QueryInput struct
b01d8a0
@dullbananas
organize run_query
0e0a0a3
@dullbananas
move limit and offset
9442505
@dullbananas
QueryInput default
bf3662a
@dullbananas
rename my_person_id to me
0a72eb1
@dullbananas
fix
3959403
@dullbananas
de-duplicate sort by published
a8e8580
@dullbananas
BoxedJoins type
c0fe0d6
@dullbananas
Merge branch 'main' into better-post-view
d027d9a
@dullbananas
move and rename query type def
f604565
@dullbananas
refactor top sort
a7885e5
@dullbananas
Merge branch 'main' into better-post-view
a9922c3
@dullbananas
Merge branch 'main' into better-post-view
98eb790
@dullbananas
comment about lifetime error
d939f26
@dullbananas
filter_with_var function
303b792
@dullbananas dullbananas mentioned this pull request Dec 9, 2023
Closed
@dullbananas
post view stuff (#18)
80f8f8b 
* Update post_view.rs

* person_insert_form, local_user_form

* Update post_view.rs

* Update post_view.rs

* Update post_view.rs

* Update post_view.rs

* Update post_view.rs

* Update post_view.rs

* Update post_view.rs

* Update post_view.rs

* Update post_view.rs

* Update post_view.rs

* Update post_view.rs

* Update post_view.rs

* Update post_view.rs

* Update post_view.rs

* Update post_view.rs

* Update lib.rs

* Update utils.rs

* Update post_view.rs

* Update post_view.rs

* Update post_view.rs
@dullbananas
fix
55bc849
@dullbananas
Merge branch 'main' into better-post-view
665b711
@dullbananas
Fix pagination test
e970e92
@dullbananas
Fix
babf23f
@dullbananas
fix
c26b24b
@dullbananas
replace unwrap with expect
dded8f0
@dullbananas
fix pagination
402ed75
@dullbananas
fix
0a05ab0
@dullbananas
fmt
236a03b
@dullbananas
fix
5ce66ec
@dullbananas
try to fix type inference
93ab08c
@dullbananas
Update post_view.rs
87d2929
@dullbananas
fix
17289af
@dullbananas
Update post_view.rs
60b438e
@dullbananas
fix
a48d181
@dullbananas
fmt
9a05618
@dullbananas
fix
7bb0018
@dullbananas
ignore pre-existing posts in pagination test
ee0fc05
@Nutomic
Copy link
Member

Nutomic commented Dec 11, 2023

I would really prefer if you could make smaller PRs that can get reviewed and merged within a week or so. With a huge PR like this which spans 2 months and 160 commits, its extremely hard to understand what was changed and review it properly.

@dullbananas
Copy link
Collaborator Author

This PR takes a long time because it involves a lot of experimentation with different designs, but I will move some of the chages (and maybe the changes to tests) to separate PRs

@Nutomic
Copy link
Member

Nutomic commented May 17, 2024

Outdated, feel free to reopen when you work on it again.

@Nutomic Nutomic closed this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nutomic Nutomic Awaiting requested review from Nutomic Nutomic will be requested when the pull request is marked ready for review Nutomic is a code owner

@dessalines dessalines Awaiting requested review from dessalines dessalines will be requested when the pull request is marked ready for review dessalines is a code owner

@phiresky phiresky Awaiting requested review from phiresky phiresky will be requested when the pull request is marked ready for review phiresky is a code owner

@SleeplessOne1917 SleeplessOne1917 Awaiting requested review from SleeplessOne1917 SleeplessOne1917 will be requested when the pull request is marked ready for review SleeplessOne1917 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dullbananas @Nutomic