-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for CAN logging #342
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been doing a bunch of data logging in my Corvette lately, so that's gotten me motivated to improve the logger.
There are a couple of UI changes that I think most people will appreciate. First, the "start/stop recording" button is much bigger, so it's easier to press it with your thumb while you're driving. :) Second, all of the parameters are now always displayed on the left side of the window.
And, since I have a couple of CAN devices in my Corvette, so I added support for CAN logging. Currently, only one CAN interface is supported. But, it's cheap:
https://www.seeedstudio.com/USB-CAN-Analyzer-p-2888.html
If you need AFR in your logs, I recommend AEM's X-Series gauges, which support support CAN, so you don't need to wire them into your PCM.
There are also a few new log parameters for the 7603 operating system, but I have to admit that not all of them are reliable.
There are also a couple of tiny improvments to PCM Hammer. The long pause before "Kernel upload 48%" always makes my heart skip a beat, so now it prints "Permission to upload granted" before it start the upload. Also, it logs the VPW messages for OBDX devices.
The next things on my to-do list - which probably won't happen in this order, but which will probably happen: