Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding coverage for coin modules #6859

Merged
merged 2 commits into from
May 15, 2024
Merged

Conversation

sprohaszka-ledger
Copy link
Contributor

@sprohaszka-ledger sprohaszka-ledger commented May 14, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Add quick setup for test coverage on coin-modules only.

Added on script to launch coverage report on all coin-modules, gather them and aggregate their results in a single report: pnpm coin:coverage (pnpm coin:coverage:clean to remove report).
To check the report, just open the generate file ./coverage/index.html

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented May 14, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback May 15, 2024 8:58am
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview May 15, 2024 8:58am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview May 15, 2024 8:58am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 15, 2024 8:58am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 15, 2024 8:58am

Copy link

New dependencies detected. Learn more about Socket for GitHub β†—οΈŽ

Package New capabilities Transitives Size Publisher
npm/nyc@15.1.0 environment, filesystem, unsafe Transitive: eval, shell +122 19.4 MB coreyfarrell

View full reportβ†—οΈŽ

lvndry
lvndry previously approved these changes May 15, 2024
@sprohaszka-ledger sprohaszka-ledger marked this pull request as ready for review May 15, 2024 08:48
@sprohaszka-ledger sprohaszka-ledger requested a review from a team as a code owner May 15, 2024 08:48
Signed-off-by: StΓ©phane Prohaszka <stephane.prohaszka@ledger.fr>
Signed-off-by: StΓ©phane Prohaszka <stephane.prohaszka@ledger.fr>
Copy link
Contributor

@lambertkevin lambertkevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this πŸ™
Just 2 comments before merging it:

  • Rather than having a clean method, shouldn't we simply gitignore all "coverage" folders ?
  • As it might not be fetched right now by a codecov like service, maybe switching the more human readable coverage reporter like html ? I'm pretty sure we can even have multiple reporters so json and html might be nice πŸ‘Œ

@sprohaszka-ledger
Copy link
Contributor Author

Thanks for this πŸ™ Just 2 comments before merging it:

  • Rather than having a clean method, shouldn't we simply gitignore all "coverage" folders ?
  • As it might not be fetched right now by a codecov like service, maybe switching the more human readable coverage reporter like html ? I'm pretty sure we can even have multiple reporters so json and html might be nice πŸ‘Œ

@lambertkevin
The "coverage" directories are all ignored ;)
I use the "json" files to generate the report. I can detail it, but I use the "html" report generate by Istanbul in the last stage of the coverage (in the generate dir: ./coverage/index.html)

Copy link
Contributor

@lambertkevin lambertkevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘

@sprohaszka-ledger sprohaszka-ledger merged commit cfb5d27 into develop May 15, 2024
58 checks passed
@sprohaszka-ledger sprohaszka-ledger deleted the support/coin-coverage branch May 15, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants