-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding coverage for coin modules #6859
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
4 Ignored Deployments
|
New dependencies detected. Learn more about Socket for GitHub βοΈ
|
Signed-off-by: StΓ©phane Prohaszka <stephane.prohaszka@ledger.fr>
Signed-off-by: StΓ©phane Prohaszka <stephane.prohaszka@ledger.fr>
74542f8
to
5c77bad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this π
Just 2 comments before merging it:
- Rather than having a clean method, shouldn't we simply gitignore all "coverage" folders ?
- As it might not be fetched right now by a codecov like service, maybe switching the more human readable coverage reporter like html ? I'm pretty sure we can even have multiple reporters so json and html might be nice π
@lambertkevin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π
β Checklist
npx changeset
was attached.π Description
Add quick setup for test coverage on coin-modules only.
Added on script to launch coverage report on all coin-modules, gather them and aggregate their results in a single report:
pnpm coin:coverage
(pnpm coin:coverage:clean
to remove report).To check the report, just open the generate file
./coverage/index.html
β Context
π§ Checklist for the PR Reviewers