Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove SubAccount type usage #6854

Merged
merged 1 commit into from
May 15, 2024
Merged

chore: remove SubAccount type usage #6854

merged 1 commit into from
May 15, 2024

Conversation

sprohaszka-ledger
Copy link
Contributor

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Related to the sunset of ChildAccount, remove the use of SubAccount for direct use of TokenAccount.

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@sprohaszka-ledger
chore: remove SubAccount type usage
bad392c 
Signed-off-by: Stéphane Prohaszka <stephane.prohaszka@ledger.fr>
@vercel Vercel
Copy link

vercel bot commented May 14, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 0:17am
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) May 14, 2024 0:17am
ledger-live-github-bot ⬜️ Ignored (Inspect) May 14, 2024 0:17am
native-ui-storybook ⬜️ Ignored (Inspect) May 14, 2024 0:17am
react-ui-storybook ⬜️ Ignored (Inspect) May 14, 2024 0:17am

@sprohaszka-ledger sprohaszka-ledger marked this pull request as ready for review May 14, 2024 13:00
@sprohaszka-ledger sprohaszka-ledger requested a review from a team as a code owner May 14, 2024 13:00
lvndry
lvndry approved these changes May 15, 2024
View reviewed changes
libs/coin-framework/src/account/helpers.ts
@@ -113,12 +107,12 @@ export function clearAccount<T extends AccountLike>(
return copy as T;
}

export function findSubAccountById(account: Account, id: string): SubAccount | null | undefined {
export function findSubAccountById(account: Account, id: string): TokenAccount | null | undefined {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the value can be null ?

@sprohaszka-ledger sprohaszka-ledger merged commit d4d5aab into develop May 15, 2024
59 checks passed
@sprohaszka-ledger sprohaszka-ledger deleted the support/coin-remove-subaccount branch May 15, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lvndry lvndry lvndry approved these changes

Assignees

@sprohaszka-ledger sprohaszka-ledger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sprohaszka-ledger @lvndry