feat(LIVE-9638): change provider info from static object to API call #6853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
live-github-bot
bot
added
mobile
lpaquet-ledger
force-pushed
the
feat/LIVE-9638
branch
from
39fab57
to
268c3e1
Compare
CremaFR
reviewed
May 15, 2024
| @@ -90,11 +90,15 @@ export async function fetchRates({ | |||
| } | |||
|
|
|||
| const url = new URL(`${getSwapAPIBaseURL()}/rate`); | |||
| const providers = await getAvailableProviders(); | |||
| if (removeProviders["moonpay"]) { | |||
| providers.splice(providers.indexOf("moonpay"), 1); | |||
There was a problem hiding this comment.
shouldn't it this moonpay coming from a Feature Flag or something, seems odd rn
There was a problem hiding this comment.
Oh nvm imo we should have it generic and loop on all keys of removeProviders
CremaFR
approved these changes
May 16, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Change static provider info to an API call
❓ Context
https://ledgerhq.atlassian.net/browse/LIVE-9638
🧐 Checklist for the PR Reviewers