Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SUPPORT]: Fix generate Accounts+NFTs #6851

Merged
merged 3 commits into from
May 15, 2024

Conversation

mcayuelas-ledger
Copy link
Contributor

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Fix generate Accounts+NFTs in Debug

  • Add new NFTs
  • Remove old NFTs (some were spams)
  • Only Top collections on Opensea
  • New way to generate NFTs
Screen_Recording_20240514_132448_LL.DEV.mp4

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@mcayuelas-ledger mcayuelas-ledger requested review from a team as code owners May 14, 2024 11:31
Copy link

vercel bot commented May 14, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools ❌ Failed (Inspect) May 14, 2024 2:58pm
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview May 14, 2024 2:58pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview May 14, 2024 2:58pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 14, 2024 2:58pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 14, 2024 2:58pm

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label May 14, 2024
lvndry
lvndry previously approved these changes May 14, 2024
LucasWerey
LucasWerey previously approved these changes May 14, 2024
Copy link
Member

@KVNLS KVNLS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸŽ‰

@mcayuelas-ledger mcayuelas-ledger merged commit b9f1f71 into develop May 15, 2024
54 of 56 checks passed
@mcayuelas-ledger mcayuelas-ledger deleted the support/fix-nft-generate branch May 15, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants