Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[B2CQA][Detox] Reduce NTFGallery et WebView testing flakiness #6849

Merged
merged 2 commits into from
May 16, 2024

Conversation

abdurrahman-ledger
Copy link
Contributor

@abdurrahman-ledger abdurrahman-ledger commented May 14, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • NFT filter animation

πŸ“ Description

Trying to mitigate some flakiness on Detox tests :

  • nftGallery : disabling NFT gallery filter animation when testing which prevented filter to appear
  • onboardingReadOnly and market : disabling WebView check on Android (not reliable)

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@abdurrahman-ledger abdurrahman-ledger requested review from a team as code owners May 14, 2024 07:55
Copy link

vercel bot commented May 14, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview May 14, 2024 7:58am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview May 14, 2024 7:58am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 14, 2024 7:58am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 14, 2024 7:58am
web-tools ⬜️ Ignored (Inspect) Visit Preview May 14, 2024 7:58am

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label May 14, 2024
@abdurrahman-ledger abdurrahman-ledger merged commit 8a065af into develop May 16, 2024
38 of 40 checks passed
@abdurrahman-ledger abdurrahman-ledger deleted the support/B2CQA_Detox_fix_flakiness branch May 16, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants