fix: prevent app to crash during the unlock phase #6848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Ignored Deployments
|
this may reveal another race condition that this PR however don't fix but will help locate it
KVNLS
approved these changes
May 16, 2024
mcayuelas-ledger
pushed a commit
that referenced
this pull request
May 20, 2024
* fix: prevent app to crash during the unlock phase this may reveal another race condition that this PR however don't fix but will help locate it * bug: protect IsUnlocked from race conditions on multiple form submit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Some users seems to experience an issue with accounts being null, this can be caused when the accounts are encrypted and something fail to decrypt it in time,
this may indicate race condition around https://github.com/LedgerHQ/ledger-live/blob/develop/apps/ledger-live-desktop/src/renderer/components/IsUnlocked.tsx#L44-L55 but at least we contain the error into the management of this code scope instead of a fatal crash that occurs in prod today.
this may reveal another race condition that this PR however don't fix but will help locate it.
❓ Context
🧐 Checklist for the PR Reviewers