Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added icon for CAEL token #6841

Closed
wants to merge 1 commit into from
Closed

Conversation

xrpsystems
Copy link

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bugfixes, you can explain the previous behavior and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@xrpsystems xrpsystems requested a review from a team as a code owner May 13, 2024 09:12
Copy link

vercel bot commented May 13, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback May 13, 2024 9:16am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview May 13, 2024 9:16am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 13, 2024 9:16am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 13, 2024 9:16am

Copy link

vercel bot commented May 13, 2024

@xrpsystems is attempting to deploy a commit to the LedgerHQ Team on Vercel.

A member of the Team first needs to authorize it.

@live-github-bot live-github-bot bot added ui Has changes in the design system library fork Pull request base branch comes from a fork. labels May 13, 2024
@gre
Copy link
Contributor

gre commented May 20, 2024

Thanks for the PR.

<defs><style>.fil2{fill:#fff}</style></defs><g id="Layer_x0020_1">

style and id attributes => i think our importer won't support this.

@xrpsystems
Copy link
Author

got you and will fix it

@xrpsystems xrpsystems closed this May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fork Pull request base branch comes from a fork. ui Has changes in the design system library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants