Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(llm): cosmos error message for stake #6832

Merged
merged 1 commit into from
May 17, 2024
Merged

fix(llm): cosmos error message for stake #6832

merged 1 commit into from
May 17, 2024

Conversation

LucasWerey
Copy link
Contributor

@LucasWerey LucasWerey commented May 10, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • Cosmos staking

📝 Description

Fix error message for cosmos staking. It was showing minimum amount : 0000 when we wanted to stake more than the current balance

Before After
image image

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@LucasWerey LucasWerey requested a review from a team as a code owner May 10, 2024 09:29
Copy link

vercel bot commented May 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) May 10, 2024 9:31am
ledger-live-github-bot ⬜️ Ignored (Inspect) May 10, 2024 9:31am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 10, 2024 9:31am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 10, 2024 9:31am
web-tools ⬜️ Ignored (Inspect) Visit Preview May 10, 2024 9:31am

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label May 10, 2024
@LucasWerey LucasWerey changed the title 🦟(llm): fix cosmos error message for stake fix(llm): cosmos error message for stake May 13, 2024
Copy link
Contributor

@hzheng-ledger hzheng-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@sshmaxime sshmaxime merged commit cfbf9c0 into develop May 17, 2024
40 of 46 checks passed
@sshmaxime sshmaxime deleted the fix/LIVE-12485 branch May 17, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants