[Coin Fmk] Batcher moving to Network #6819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
lvndry
previously approved these changes
May 15, 2024
| } | ||
|
|
||
| response = await retry(() => axios(request), { | ||
| maxRetry: getEnv("GET_CALLS_RETRY"), |
There was a problem hiding this comment.
Do you think it'd make sense to also have maxRetry this in LiveNetworkRequest ?
There was a problem hiding this comment.
What bothering me, is that this is not part of the live-network package.
I think we should do, but maybe with a small refacto.
Signed-off-by: Stéphane Prohaszka <stephane.prohaszka@ledger.fr>
Signed-off-by: Stéphane Prohaszka <stephane.prohaszka@ledger.fr>
Signed-off-by: Stéphane Prohaszka <stephane.prohaszka@ledger.fr>
Signed-off-by: Stéphane Prohaszka <stephane.prohaszka@ledger.fr>
sprohaszka-ledger
force-pushed
the
support/coin-fmk-batcher
branch
from
e22a40e
to
da1ca6a
Compare
lambertkevin
approved these changes
May 21, 2024
lvndry
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Move Batcher from
coin-frameworktolive-network.Might need to consider to expands this concept.
Also propose a new
networkfunction to get rid of Axios type (this is a good practice to partition types of external libraries). This method is compatible with the old one.OLD implementation
NEW implementation
❓ Context
🧐 Checklist for the PR Reviewers