-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/add xahau xah #6807
base: develop
Are you sure you want to change the base?
Feat/add xahau xah #6807
Conversation
commit 1756f14 Author: Wietse Wind <mail@wietse.com> Date: Fri Apr 19 16:17:00 2024 +0200 Pass currency to submit operation and use to select network commit cba95db Author: Wietse Wind <mail@wietse.com> Date: Fri Apr 19 16:06:09 2024 +0200 Import encode from binary codec for XRPL & Xahau (mjs) commit 55dc3db Author: Wietse Wind <mail@wietse.com> Date: Fri Apr 19 16:00:28 2024 +0200 Remove debug logging commit d09117c Author: Wietse Wind <mail@wietse.com> Date: Fri Apr 19 16:00:22 2024 +0200 Respect network querying network info commit e1868a2 Author: Wietse Wind <mail@wietse.com> Date: Fri Apr 19 16:00:05 2024 +0200 Allow for XRPL/Xahauu RPC endpoint based on object / string commit b4028e3 Author: Wietse Wind <mail@wietse.com> Date: Fri Apr 19 15:59:47 2024 +0200 Alias xahau as ripple-based protocol commit c70f9d9 Author: Wietse Wind <mail@wietse.com> Date: Fri Apr 19 15:33:15 2024 +0200 Add Xahau & XRPL explorers commit fb9ca8f Author: Wietse Wind <mail@wietse.com> Date: Fri Apr 19 15:33:09 2024 +0200 Fix Xahau explorer commit a3203dd Author: Wietse Wind <mail@wietse.com> Date: Fri Apr 19 15:28:59 2024 +0200 Add support for Xahau (alt XRPL Protocol) @ ripple family commit 55a322c Author: Wietse Wind <mail@wietse.com> Date: Fri Apr 19 14:46:32 2024 +0200 XRPL Protocol = same BIP, normalise bridge commit efb2c1a Author: Wietse Wind <mail@wietse.com> Date: Fri Apr 19 14:46:12 2024 +0200 appName = token code commit 7839fda Author: Wietse Wind <mail@wietse.com> Date: Fri Apr 19 13:42:19 2024 +0200 abandonSeedAddresses for Xahau as well commit 06eaf82 Author: Wietse Wind <mail@wietse.com> Date: Fri Apr 19 13:42:11 2024 +0200 XRPL sister chains need different codec commit bf8f0f2 Author: Wietse Wind <mail@wietse.com> Date: Fri Apr 19 13:41:38 2024 +0200 Add XAH (Xahau) to supported currency list (mobile) commit d028c01 Author: Wietse Wind <mail@wietse.com> Date: Fri Apr 19 13:41:25 2024 +0200 Addh XAH app to common commit aec4caf Author: Wietse Wind <mail@wietse.com> Date: Fri Apr 19 13:41:04 2024 +0200 Dependency: xrpl-binary-codec-prerelease to support XRPL & sister chains commit 7716131 Author: Wietse Wind <mail@wietse.com> Date: Fri Apr 19 03:33:02 2024 +0200 Prepare for TX on XRPL Protocol with NetworkID commit 7d1dc6f Author: Wietse Wind <mail@wietse.com> Date: Fri Apr 19 02:54:42 2024 +0200 Add XAH app to readme commit 0d991bc Author: Wietse Wind <mail@wietse.com> Date: Fri Apr 19 02:54:31 2024 +0200 hw-app-xah: multi chain binary codec commit 929e4a5 Author: Wietse Wind <mail@wietse.com> Date: Fri Apr 19 02:54:14 2024 +0200 ripple-binary-codec » xrpl-binary-codec for multi network support commit 5a0bba3 Author: Wietse Wind <mail@wietse.com> Date: Fri Apr 19 02:53:50 2024 +0200 ripple-binary-codec » xrpl-binary-codec commit 0f642ae Author: Wietse Wind <mail@wietse.com> Date: Fri Apr 19 02:53:11 2024 +0200 Fix XAH readme commit 30d3914 Author: Wietse Wind <mail@wietse.com> Date: Fri Apr 19 01:41:59 2024 +0200 Add hw app XAH commit 66abe9b Author: Wietse Wind <mail@wietse.com> Date: Thu Apr 18 17:05:06 2024 +0200 Add XAH mock commit a396d9a Author: Wietse Wind <mail@wietse.com> Date: Thu Apr 18 17:05:01 2024 +0200 Add supported currency commit a0662dc Author: Wietse Wind <mail@wietse.com> Date: Thu Apr 18 17:04:52 2024 +0200 Update network vs token name commit cbfcddc Author: Wietse Wind <mail@wietse.com> Date: Thu Apr 18 16:44:33 2024 +0200 Xahau uses xrpl (ripple) family commit ca44737 Author: Wietse Wind <mail@wietse.com> Date: Thu Apr 18 16:42:16 2024 +0200 Adding XAH (Xahau network), SLIP # pending PR commit 8eeedc9 Author: Wietse Wind <mail@wietse.com> Date: Thu Apr 18 16:41:08 2024 +0200 Adding XAHAU RPC endpoint @ xahau.org commit cb84700 Author: Wietse Wind <mail@wietse.com> Date: Thu Apr 18 16:40:55 2024 +0200 CLI: tag (Destination Tag) = both XRPL & Xahau commit e46f270 Author: Wietse Wind <mail@wietse.com> Date: Thu Apr 18 16:07:10 2024 +0200 Add XAH icon
commit 1756f14 Author: Wietse Wind <mail@wietse.com> Date: Fri Apr 19 16:17:00 2024 +0200 Pass currency to submit operation and use to select network commit cba95db Author: Wietse Wind <mail@wietse.com> Date: Fri Apr 19 16:06:09 2024 +0200 Import encode from binary codec for XRPL & Xahau (mjs) commit 55dc3db Author: Wietse Wind <mail@wietse.com> Date: Fri Apr 19 16:00:28 2024 +0200 Remove debug logging commit d09117c Author: Wietse Wind <mail@wietse.com> Date: Fri Apr 19 16:00:22 2024 +0200 Respect network querying network info commit e1868a2 Author: Wietse Wind <mail@wietse.com> Date: Fri Apr 19 16:00:05 2024 +0200 Allow for XRPL/Xahauu RPC endpoint based on object / string commit b4028e3 Author: Wietse Wind <mail@wietse.com> Date: Fri Apr 19 15:59:47 2024 +0200 Alias xahau as ripple-based protocol commit c70f9d9 Author: Wietse Wind <mail@wietse.com> Date: Fri Apr 19 15:33:15 2024 +0200 Add Xahau & XRPL explorers commit fb9ca8f Author: Wietse Wind <mail@wietse.com> Date: Fri Apr 19 15:33:09 2024 +0200 Fix Xahau explorer commit a3203dd Author: Wietse Wind <mail@wietse.com> Date: Fri Apr 19 15:28:59 2024 +0200 Add support for Xahau (alt XRPL Protocol) @ ripple family commit 55a322c Author: Wietse Wind <mail@wietse.com> Date: Fri Apr 19 14:46:32 2024 +0200 XRPL Protocol = same BIP, normalise bridge commit efb2c1a Author: Wietse Wind <mail@wietse.com> Date: Fri Apr 19 14:46:12 2024 +0200 appName = token code commit 7839fda Author: Wietse Wind <mail@wietse.com> Date: Fri Apr 19 13:42:19 2024 +0200 abandonSeedAddresses for Xahau as well commit 06eaf82 Author: Wietse Wind <mail@wietse.com> Date: Fri Apr 19 13:42:11 2024 +0200 XRPL sister chains need different codec commit bf8f0f2 Author: Wietse Wind <mail@wietse.com> Date: Fri Apr 19 13:41:38 2024 +0200 Add XAH (Xahau) to supported currency list (mobile) commit d028c01 Author: Wietse Wind <mail@wietse.com> Date: Fri Apr 19 13:41:25 2024 +0200 Addh XAH app to common commit aec4caf Author: Wietse Wind <mail@wietse.com> Date: Fri Apr 19 13:41:04 2024 +0200 Dependency: xrpl-binary-codec-prerelease to support XRPL & sister chains commit 7716131 Author: Wietse Wind <mail@wietse.com> Date: Fri Apr 19 03:33:02 2024 +0200 Prepare for TX on XRPL Protocol with NetworkID commit 7d1dc6f Author: Wietse Wind <mail@wietse.com> Date: Fri Apr 19 02:54:42 2024 +0200 Add XAH app to readme commit 0d991bc Author: Wietse Wind <mail@wietse.com> Date: Fri Apr 19 02:54:31 2024 +0200 hw-app-xah: multi chain binary codec commit 929e4a5 Author: Wietse Wind <mail@wietse.com> Date: Fri Apr 19 02:54:14 2024 +0200 ripple-binary-codec » xrpl-binary-codec for multi network support commit 5a0bba3 Author: Wietse Wind <mail@wietse.com> Date: Fri Apr 19 02:53:50 2024 +0200 ripple-binary-codec » xrpl-binary-codec commit 0f642ae Author: Wietse Wind <mail@wietse.com> Date: Fri Apr 19 02:53:11 2024 +0200 Fix XAH readme commit 30d3914 Author: Wietse Wind <mail@wietse.com> Date: Fri Apr 19 01:41:59 2024 +0200 Add hw app XAH commit 66abe9b Author: Wietse Wind <mail@wietse.com> Date: Thu Apr 18 17:05:06 2024 +0200 Add XAH mock commit a396d9a Author: Wietse Wind <mail@wietse.com> Date: Thu Apr 18 17:05:01 2024 +0200 Add supported currency commit a0662dc Author: Wietse Wind <mail@wietse.com> Date: Thu Apr 18 17:04:52 2024 +0200 Update network vs token name commit cbfcddc Author: Wietse Wind <mail@wietse.com> Date: Thu Apr 18 16:44:33 2024 +0200 Xahau uses xrpl (ripple) family commit ca44737 Author: Wietse Wind <mail@wietse.com> Date: Thu Apr 18 16:42:16 2024 +0200 Adding XAH (Xahau network), SLIP # pending PR commit 8eeedc9 Author: Wietse Wind <mail@wietse.com> Date: Thu Apr 18 16:41:08 2024 +0200 Adding XAHAU RPC endpoint @ xahau.org commit cb84700 Author: Wietse Wind <mail@wietse.com> Date: Thu Apr 18 16:40:55 2024 +0200 CLI: tag (Destination Tag) = both XRPL & Xahau commit e46f270 Author: Wietse Wind <mail@wietse.com> Date: Thu Apr 18 16:07:10 2024 +0200 Add XAH icon
…o feat/add-xahau-xah # Conflicts: # apps/ledger-live-desktop/cryptoassets.md
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Ignored Deployments
|
@WietseWind is attempting to deploy a commit to the LedgerHQ Team on Vercel. A member of the Team first needs to authorize it. |
Wiz Scan Summary
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
There as been no activity on this PR for the last 14 days. Please consider closing this PR. |
@@ -144,6 +144,7 @@ | |||
"winston": "^3.2.1", | |||
"winston-transport": "^4.3.0", | |||
"write-file-atomic": "^5.0.0", | |||
"xrpl-binary-codec-prerelease": "^8.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any reference to this in ledger-live-desktop
project, why was it added ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for reviewing.
It is a replacement of ripple-binary-codec
, where ripple-binary-codec
only supports the native XRPL chains, with fixed network definitions: so whenever a new transaction type, field or amendment is introduced, it needs an update - as mentioned @ "Impact of changes" in this PR.
This package (xrpl-binary-codec-prerelease
) implements dynamic network definitions as served by both XRPL and other similar protocol chains over RPC, so it can always deal with new TX types fields & netwoks.
The changes to make this possible have been PR'ed into ripple-binary-codec
but haven't been merged for ages. Several projects now use xrpl-binary-codec-prerelease
and most multi chain wallets with XRPL protocol support are using this one now.
-- See https://www.npmjs.com/package/xrpl-binary-codec-prerelease
XRPLF/xrpl.js@main...WietseWind:xrpl.js:main
(Fork of xrpl.js with the appropriate changes, the monorepo by Rippl)
Actively maintained by me, at https://github.com/xrpl-labs
✅ Checklist
npx changeset
was attached.ripple-binary-codec
with a network-independent version of the lib. as used in the XRPL ecosystem📝 Description
The XRP Ledger (Ripple) has another network in its ecosystem, called Xahau, which is XRP Ledger protocol but with native smart contracts added, and some new transaction types. There's overlap in the ecosystem, but the networks are separate.
This PR adds Xahau network and the native XAH asset to the Ledger Live Desktop and Mobile client, while keeping the libs used as much common to support both networks as possible.
❓ Context
Xahau/app-xah#1
🧐 Checklist for the PR Reviewers