[Fix/stacks] Optimistic operation disappears for long running transactions

[lawRathod]

✅ Checklist

• npx changeset was attached.
• Covered by automatic tests.
• Impact of the changes:
  • ...

📝 Description

The optimistics transaction disappears when transactions on stacks network takes long time. The pending operations are now added to accounts object during sync to fix the problem.

❓ Context

• JIRA or GitHub link: https://ledgerhq.atlassian.net/browse/LIVE-10510

---

🧐 Checklist for the PR Reviewers

• The code aligns with the requirements described in the linked JIRA or GitHub issue.
• The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
• There are no undocumented trade-offs, technical debt, or maintainability issues.
• The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
• Any new dependencies have been justified and documented.
• Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
web-tools	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 28, 2024 3:27pm

3 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
ledger-live-docs	⬜️ Ignored (Inspect)	Visit Preview		May 28, 2024 3:27pm
native-ui-storybook	⬜️ Ignored (Inspect)	Visit Preview		May 28, 2024 3:27pm
react-ui-storybook	⬜️ Ignored (Inspect)	Visit Preview		May 28, 2024 3:27pm

[vercel]

@lawRathod is attempting to deploy a commit to the LedgerHQ Team on Vercel.

A member of the Team first needs to authorize it.

[github-actions]

There as been no activity on this PR for the last 14 days. Please consider closing this PR.

[hzheng-ledger]

Please see my comments

[hzheng-ledger]

it looks good to me.
I've some questions,
I don't know whether the balance return from /extended/v1/address/${addr}/stx includes the pending transactions(mempool transactions)

I see this piece of code

  for (const tx of mempoolTxs) {
    spendableBalance = spendableBalance
      .minus(new BigNumber(tx.fee_rate))
      .minus(new BigNumber(tx.token_transfer.amount));
  }

Does the mempoolTxs includes both incoming and outgoing (send and receive) transactions?
because the "fee_rate" is not paid by the current account for receive transactions.
should we give the "tx.token_transfer.amount" a positive or negative value according to send/receive transaction?

[lawRathod]

@hzheng-ledger Thanks for the review.

whether the balance return from /extended/v1/address/${addr}/stx includes the pending transactions(mempool transactions)

Only sent transactions are part of the mempool txns object https://github.com/Zondax/ledger-live/blob/develop/libs/ledger-live-common/src/families/stacks/bridge/utils/api.ts#L142-L147 so we substract the fee and amount from the balance.

[hzheng-ledger]

it looks good to me. thanks

[hzheng-ledger]

we shouldn't add pendingOperations here.
This pendingOperations is used for new broadcasted transaction from our UI. (not even necessarily in mempool, but we want to display them to users in our Ledger live) It is for different usage.

what we should do here is to merge flatMap(rawTxs, mapTxToOps(accountId)) and flatMap(mempoolTxs, mapPendingTxToOps(accountId, address))
in the above "operations" field. for confirmed transaction, we set "blockHeight" and "blockHash" field correctly and for pending transaction in mempool, we set "blockHeight" and "blockHash" field as null. So that we can see these pending transactions in our Ledger live

the "pendingOperations" is normally not used in "getAccountShape" method

@lawRathod

[lawRathod]

thanks for the explanation, there was definitely some confusion around this but everything is much clear now. I have merged both as you suggest, please have another look 🙏🏻

[hzheng-ledger]

Please see my another comment. Thanks a lot

[hzheng-ledger]

looks good to me

[hzheng-ledger]

Thanks a lot. I've approved the PR