Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/dsdk 276 create keyring-eth module #6792

Merged
merged 2 commits into from
May 27, 2024
Merged

Feat/dsdk 276 create keyring-eth module #6792

merged 2 commits into from
May 27, 2024

Conversation

aussedatlo
Copy link
Contributor

@aussedatlo aussedatlo commented Apr 30, 2024 •
edited by jira bot

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Create keyring-eth module to implement a simple keyring interface with:

  • getAddress
  • signTransaction
  • signMessage

This PR handle two ticket:

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented Apr 30, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 27, 2024 0:34am
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview May 27, 2024 0:34am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview May 27, 2024 0:34am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 27, 2024 0:34am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 27, 2024 0:34am

@aussedatlo aussedatlo changed the base branch from develop to feat/dsdk-284-context-module-cal April 30, 2024 16:00
@live-github-bot live-github-bot bot added the ledgerjs Has changes in the ledgerjs open source libs label Apr 30, 2024
@aussedatlo aussedatlo force-pushed the feat/dsdk-284-context-module-cal branch from 8261cc8 to c23a6a8 Compare May 3, 2024 08:31
@aussedatlo aussedatlo force-pushed the feat/dsdk-284-context-module-cal branch from c23a6a8 to df2bf9a Compare May 3, 2024 08:54
@aussedatlo aussedatlo force-pushed the feat/dsdk-284-context-module-cal branch from df2bf9a to a06bb82 Compare May 7, 2024 07:37
@aussedatlo aussedatlo marked this pull request as draft May 7, 2024 07:40
@aussedatlo aussedatlo force-pushed the feat/dsdk-284-context-module-cal branch 10 times, most recently from cb53f9f to 0bde643 Compare May 16, 2024 10:32
Base automatically changed from feat/dsdk-284-context-module-cal to develop May 17, 2024 13:33
@socket-security Socket Security

This comment was marked as outdated.

Sign in to view
@aussedatlo aussedatlo marked this pull request as ready for review May 27, 2024 08:29
@aussedatlo aussedatlo requested a review from a team as a code owner May 27, 2024 08:29
lambertkevin
lambertkevin previously approved these changes May 27, 2024
View reviewed changes
Copy link
Contributor

@lambertkevin lambertkevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question, and it's more a (nice to have) feature request than anything 👍

libs/ledgerjs/packages/keyring-eth/src/KeyringEth.ts Outdated Show resolved Hide resolved
@aussedatlo aussedatlo merged commit 4855793 into develop May 27, 2024
56 checks passed
@aussedatlo aussedatlo deleted the feat/dsdk-276-keyring-eth branch May 27, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lambertkevin lambertkevin lambertkevin approved these changes

@ofreyssinet-ledger ofreyssinet-ledger ofreyssinet-ledger left review comments

Assignees

@aussedatlo aussedatlo

Labels
ledgerjs Has changes in the ledgerjs open source libs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aussedatlo @lambertkevin @ofreyssinet-ledger