-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/dsdk 285 create context module nft loaders #6789
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
4 Ignored Deployments
|
8261cc8
to
a0a7bc9
Compare
ccf918a
to
b9d0fde
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only 1 change that seems required because I think we're always throwing instead of just letting it go through for domains. Other than that, it's just minor recommendations π
libs/ledgerjs/packages/context-module/src/DefaultContextModule.ts
Outdated
Show resolved
Hide resolved
libs/ledgerjs/packages/context-module/src/loaders/ForwardDomainLoader.ts
Outdated
Show resolved
Hide resolved
libs/ledgerjs/packages/context-module/src/loaders/ForwardDomainLoader.ts
Outdated
Show resolved
Hide resolved
libs/ledgerjs/packages/context-module/src/loaders/NftLoader.test.ts
Outdated
Show resolved
Hide resolved
a0a7bc9
to
5fe1e51
Compare
libs/ledgerjs/packages/context-module/src/loaders/TokenLoader.ts
Outdated
Show resolved
Hide resolved
5fe1e51
to
0938823
Compare
fab39b4
to
7f7f196
Compare
0938823
to
ecaf487
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just 1 minor & optional addition. Otherwise π
...edgerjs/packages/context-module/src/forward-domain/domain/ForwardDomainContextLoader.test.ts
Outdated
Show resolved
Hide resolved
56b0861
to
870818e
Compare
ecaf487
to
550ff5f
Compare
The base branch was changed.
β Checklist
npx changeset
was attached.π Description
Implement DomainLoader and NftLoader to get metadatas used to cleasign a transaction.
This PR correspond to:
β Context
π§ Checklist for the PR Reviewers