Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timesheet fixes for invalid data #2498

Merged
merged 6 commits into from May 2, 2024
Merged

Conversation

marcelfolaron
Copy link
Contributor

Description

Fix timesheet data issue by disallowing adding entries in the wrong timezone.
There were several timezone collisions that could happen and those cannot be resolved automatically. As such we are disabling the ability to add additional weekday entries for timesheet rows that were added in different timezones.

Screenshot of the result

image

Checklist

  • [ x] My code passes all test cases.
  • [ x] My code passes our static analysis suite.
  • [ x] My code passes our continuous integration process.

If your code does not pass the requirements on the checklist, you should add a comment explaining why this change
should be exempt from the list.

Additional comments or questions

If you have any further comments or questions for the reviewer, please add them here.

@marcelfolaron marcelfolaron requested a review from a team as a code owner May 2, 2024 17:01
@marcelfolaron marcelfolaron requested review from broskees and removed request for a team May 2, 2024 17:01
@marcelfolaron marcelfolaron merged commit 281bb2d into master May 2, 2024
5 checks passed
@marcelfolaron marcelfolaron deleted the timesheetFixesForInvalidData branch May 2, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant