Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default theme fixes #2491

Merged
merged 4 commits into from Apr 29, 2024
Merged

Default theme fixes #2491

merged 4 commits into from Apr 29, 2024

Conversation

marcelfolaron
Copy link
Contributor

Link to ticket

#2470 #2473

Fix theme settings saving
Double check that config language is valid as well

Description

Please include a short description of the suggested change and the reasoning behind the approach you have chosen.

Screenshot of the result

If your change affects the user interface, you should include a screenshot of the result with the pull request.

Checklist

  • My code passes all test cases.
  • My code passes our static analysis suite.
  • My code passes our continuous integration process.

If your code does not pass the requirements on the checklist, you should add a comment explaining why this change
should be exempt from the list.

Additional comments or questions

If you have any further comments or questions for the reviewer, please add them here.

@marcelfolaron marcelfolaron requested a review from a team as a code owner April 28, 2024 18:09
@marcelfolaron marcelfolaron requested review from broskees and removed request for a team April 28, 2024 18:09
@marcelfolaron marcelfolaron merged commit 8cae169 into master Apr 29, 2024
5 checks passed
@marcelfolaron marcelfolaron deleted the defaultThemeFixes branch April 29, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant