fixing ldap issues

Leantime · Apr 17, 2022 · 39da04e · 39da04e
1 parent c558c6e
commit 39da04e
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/resources/logs/error.log b/resources/logs/error.log
@@ -0,0 +1,3 @@
+[17-Apr-2022 16:24:47 America/Los_Angeles] PHP Warning:  ldap_connect(): invalid port number: 0 in C:\xampp\htdocs\leantime-oss\src\domain\ldap\services\class.ldap.php on line 97
+[17-Apr-2022 16:24:47 America/Los_Angeles] PHP Warning:  ldap_set_option(): supplied argument is not a valid ldap link resource in C:\xampp\htdocs\leantime-oss\src\domain\ldap\services\class.ldap.php on line 99
+[17-Apr-2022 16:27:56 America/Los_Angeles] PHP Notice:  Undefined index: priority in C:\xampp\htdocs\leantime-oss\src\domain\tickets\repositories\class.tickets.php on line 1031
diff --git a/src/domain/ldap/services/class.ldap.php b/src/domain/ldap/services/class.ldap.php
@@ -93,7 +93,12 @@ private function getRoleAssignments (){
 
     public function connect() {
 
+        if(!$this->config->useLdap){
+            return false;
+        }
+
         if(function_exists("ldap_connect")) {
+
             $this->ldapConnection = ldap_connect($this->host, $this->port);
 
             ldap_set_option($this->ldapConnection, LDAP_OPT_PROTOCOL_VERSION, 3) or die('Unable to set LDAP protocol version');

diff --git a/src/domain/users/controllers/class.showAll.php b/src/domain/users/controllers/class.showAll.php
@@ -30,10 +30,6 @@ public function get()
                 $tpl->assign('admin', true);
                 $tpl->assign('roles', core\login::$userRoles);
 
-                if($ldapService->connect()) {
-                    $ldapService->getAllMembers($_SESSION['userdata']['mail'], '');
-                }
-
                 $tpl->display('users.showAll');
 
             }else{