Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added param --rootPath to store session,logs in a predefined directory. #169

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Loatchi
Copy link

@Loatchi Loatchi commented Feb 22, 2023

Summary of Changes

  • Added a parameter to the main.py program "root"
  • Changed where the session, log files are stored depending on root
  • Added {root}/config/config.yaml as a file to check when finding configs

Additional context

The idea behind this PR is to ensure that anyone trying to package this program for certain linux distributions can directly store all files in a writable directory.

Testing instructions

  • Make sure that all files/directories are properly create at root (when provided).
  • Look that the program can properly harvest config from root dir.

How to download the PR for testing

Using GitHub CLI

  1. Clone this PR
  2. Run gh pr checkout 124 (Requires GitHub CLI)
  3. Follow the Advanced Installation Guides from the Wiki

Using regular GIT

  1. Fetch the PR git fetch origin pull/<PR_NUMBER>/head:<LOCAL_BRANCH_NAME> (e.g. git fetch origin pull/110/head:notif)
  2. Checkout the branch git checkout <LOCAL_BRANCH_NAME> (e.g. git checkout notif)
  3. Follow the Advanced Installation Guides from the Wiki

@Loatchi Loatchi changed the title Feat: Added param --root to store session,logs in a predefined directory. feat: Added param --root to store session,logs in a predefined directory. Feb 22, 2023
@LeagueOfPoro
Copy link
Owner

I would suggest renaming root to rootPath just to keep it consistent with config. Other than that, looks good

@Loatchi
Copy link
Author

Loatchi commented Feb 23, 2023

Just did that !

@Loatchi Loatchi changed the title feat: Added param --root to store session,logs in a predefined directory. feat: Added param --rootPath to store session,logs in a predefined directory. Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants