feat(extras.lang): Add kotlin #2890
Merged
+104
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthur-mountain
changed the title
dpetka2001
reviewed
Apr 2, 2024
dpetka2001
reviewed
Apr 2, 2024
dpetka2001
reviewed
Apr 2, 2024
dpetka2001
reviewed
Apr 2, 2024
1. Remove kotlin language server from mason 2. Add optinal is true, only enabled if the user has explicitly enabled the extra plugin. 3. Remove duplicate dependencies cause they are already defined in the plugin. 4. Add none-ls as optional
arthur-mountain
force-pushed
the
feat/add-kotlin-into-extra-lang
branch
from
07555bc
to
22c09aa
Compare
dpetka2001
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
Looks good to me from a LazyVim configuration point of view. I don't do Kotlin however, so am unable to test the configuration. It would be really helpful if you yourself and other users (that do Kotilin) if possible could share their experience with this PR in their local configuration.
Again, I'm just a simple user, so the maintainer has the final say.
|
I truly appreciate your feedback and assistance! I'm also not an expert in Kotlin; it just so happened that I wrote some projects with Kotlin, which led me to this PR. I hope it can be helpful to users of kotlin. I also hope to receive feedback from users experienced in Kotlin. Thank you very much for your help. |
|
+1 |
|
Thanks! |
folke
pushed a commit
that referenced
this pull request
Jun 6, 2024
) ### Description I am the author of this [PR](#2890). While reviewing my own code and checking the LazyVim official website, I noticed some inconsistencies 😓 , so I created a small PR to address them: ### Changes 1.Each optional plugin has a comment message indicating that the plugin is optional, but DAP does not (as shown in the image). Since the official website already has an "optional" in title. **I removed the comment messages regarding "optional" to avoid confusion**. <img width="300" alt="Screenshot 2024-05-23 at 10 31 38 PM" src="https://github.com/LazyVim/LazyVim/assets/82575487/441979fc-20dd-4599-a91d-f27bc0841d79"> --- 2. I changed the DAP to use local variables for DAP to maintain consistency, even though both require statements reference the same module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adding kotlin support
The plugins was added
masontree-sitternvim-lspconfignvim-lint(optional)conform(optional)none-ls(optional)nvim-dap(optional)