New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added commandline interface to library #5
base: master
Are you sure you want to change the base?
Conversation
HI jwilliams99, ACK to the idea. Just 2 remarks:
|
Thanks for the feedback. This is my first python script, and I'll get the
|
comments addressed, file uploaded. |
I've done a few tests on python 3.3.3. It works fine. A few minor remarks:
For the last 2 points, I think we may use :
What do you think about it? At last, feel free to modify the README.md in order to add a chapter about this tool (before the "Integration example" chapter ?) and to add your name in the list of authors. Thanks for your contribution ! |
Point #2, you're correct, i've forgotten to update the help once i got the Your suggestion for points 2 & 3 are better than mine ;) I'm pretty happy to roll with your suggestions. My pleasure for the On 10 April 2016 at 06:29, LaurentMT notifications@github.com wrote:
|
There seems to be a bug in the cli whereby if the nonce is passed in, the if message['nonce'] == '':
doesnt seem to recognise it. my python isn't good enough to understand if you'd take a look at it, i'm sure you'd see the problem straight away ;) On 11 April 2016 at 22:14, Ryszard ryszard99@gmail.com wrote:
|
I think it's just a problem of indentation. |
Added a simple CLI so other scripts can use bitid without having to implement natively.