Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component Config injection #152

Open
3 tasks
Tracked by #151
LastDragon-ru opened this issue Apr 25, 2024 · 0 comments
Open
3 tasks
Tracked by #151

Component Config injection #152

LastDragon-ru opened this issue Apr 25, 2024 · 0 comments
Assignees
Labels
! Breaking change scope: refactor
Milestone

Comments

@LastDragon-ru
Copy link
Owner

LastDragon-ru commented Apr 25, 2024

And get rid of arrays... Because it is extremely difficult to update examples in the docs when component settings were changed. There is also no validation for settings names, difficult to rename, difficult to deprecate, etc, etc. All of them can be solved if we will use objects instead of arrays.

Internally Laravel uses var_export to cache the config, so seems objects should be fine.

  • Convert to objects
  • Make sure that existing array based config still can be used (should trigger the deprecation message)
  • Injection
@LastDragon-ru LastDragon-ru self-assigned this Apr 25, 2024
@LastDragon-ru LastDragon-ru added scope: refactor ! Breaking change labels Apr 25, 2024
@LastDragon-ru LastDragon-ru added this to the Next milestone Apr 25, 2024
@LastDragon-ru LastDragon-ru changed the title Config injection Component Config injection Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
! Breaking change scope: refactor
Projects
None yet
Development

No branches or pull requests

1 participant