Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No implicit dependencies. #151

Open
4 of 6 tasks
LastDragon-ru opened this issue Apr 25, 2024 · 0 comments
Open
4 of 6 tasks

No implicit dependencies. #151

LastDragon-ru opened this issue Apr 25, 2024 · 0 comments
Assignees
Labels
! Breaking change scope: refactor
Milestone

Comments

@LastDragon-ru
Copy link
Owner

LastDragon-ru commented Apr 25, 2024

Some time ago injection of Container/Config (and some other) were replaced by the direct call Container::getInstance() to be compatible with Octane (#38). The main problem with the current approach - implicit dependencies and (more important) implicit config (Container::getInstance()->make(Repository::class)->get(...)).

Recently I have reviewed all these places and looks like it is possible to convert all of them into explicit 🎉

@LastDragon-ru LastDragon-ru added scope: refactor ! Breaking change labels Apr 25, 2024
@LastDragon-ru LastDragon-ru added this to the Next milestone Apr 25, 2024
@LastDragon-ru LastDragon-ru self-assigned this Apr 25, 2024
This was referenced May 1, 2024
LastDragon-ru added a commit that referenced this issue May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
! Breaking change scope: refactor
Projects
None yet
Development

No branches or pull requests

1 participant