Update radio.blade.php #5502
Open
Update radio.blade.php #5502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix my problems
karandatwani92
added
Possible Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix my problems, yeah as simple as that...
WHY
Because, when my radio contains backslash () it can't be checked by previous code
BEFORE - What was wrong? What was happening before this PR?
It doesn't checked the radio because value contains backslash ()
AFTER - What is happening after this PR?
Now it can, because using filter
HOW
How did you achieve that, in technical terms?
I tried to make morph relationship, then when I put value
App\Models\Roomit can't checked the radio when I tried to edit the entryIs it a breaking change?
I think it is not, just a small fix
How can we test the before & after?
I tested and it was working both for integer value or with backslash ()