[WIP] add span to backpack button text #5343
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tabacitu
reviewed
Oct 12, 2023
Comment on lines
2
to
4
| <a href="{{ url($crud->route.'/create') }}" class="btn btn-primary" data-style="zoom-in"> | ||
| <span><i class="la la-plus"></i> {{ trans('backpack::crud.add') }} {{ $crud->entity_name }}</span> | ||
| <span><i class="la la-plus"></i> <span class="create-button-text-span">{{ trans('backpack::crud.add') }} {{ $crud->entity_name }}</span></span> | ||
| </a> |
There was a problem hiding this comment.
How about we add bp-button="create" to the anchor? That way you can style the button itself too, if needed.
There was a problem hiding this comment.
And it'd be similar to our other CSS hooks, bp-section
There was a problem hiding this comment.
tabacitu
reviewed
Oct 12, 2023
| @@ -1,6 +1,6 @@ | |||
| @if ($crud->hasAccess('delete')) | |||
| <a href="javascript:void(0)" onclick="deleteEntry(this)" data-route="{{ url($crud->route.'/'.$entry->getKey()) }}" class="btn btn-sm btn-link" data-button-type="delete"> | |||
| <span><i class="la la-trash"></i> {{ trans('backpack::crud.delete') }}</span> | |||
| <span><i class="la la-trash"></i> <span class="delete-button-text-span">{{ trans('backpack::crud.delete') }}</span></span> | |||
There was a problem hiding this comment.
Do we really need two spans? One for the entire button content, one for the text? Cause if we only need one for the text, it should be as easy as moving the span start after the icon. No class needed:
Suggested change
| <span><i class="la la-trash"></i> <span class="delete-button-text-span">{{ trans('backpack::crud.delete') }}</span></span> | |
| <i class="la la-trash"></i> <span>{{ trans('backpack::crud.delete') }}</span> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reported in #5010
we could make developers life easier when they want to hide the button text and display only an icon by wrapping the button text in a span as suggested by @tabacitu
I've decided to create a class for each button type, eg:
create-button-text-span,update-button-text-span. That way developers have the ability to hide only specific button texts, or hide all of them with*-button-text-spanselector.