Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gradle.properties #7

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

heyInvi
Copy link

@heyInvi heyInvi commented Aug 3, 2022

I'm just trying to update it to 1.19 for my curseforge settings, otherwise it just tells me the mod is incompatible. I'm really sorry if that's illegal or transgresses your ownership of the code, please tell me if that's the case

all I did was update it to the version I'm using, sorry if that's illegal or transgresses your ownership of the code, please tell me if that's the case
@Eman-3600
Copy link

Did you make sure it works?

@heyInvi
Copy link
Author

heyInvi commented Aug 3, 2022

I'm not sure if the code will let you just write it as ">=" instead of "=", which could maybe solve needing to rewrite it for future versions unless mc changes drastically in a way that affects how your code runs... I'm kinda new at this, sorry

@heyInvi
Copy link
Author

heyInvi commented Aug 3, 2022

Did you make sure it works?

genuinely don't know how, I thought this was just to make the suggestion, not create a working jar file

@Eman-3600
Copy link

Alright I'll go check it out and let you know if there's any problems. If it's all good, we'll wait to see what Doctor4t thinks

@heyInvi
Copy link
Author

heyInvi commented Aug 3, 2022

Alright I'll go check it out and let you know if there's any problems. If it's all good, we'll wait to see what Doctor4t thinks

could you help explain how you actually do that btw? or direct me to the right sources? it took a while just to learn how to make a pull request haha
and honestly yeah! if he sees this it'd be great! I'm a huge fan of his work and it kinda sucks that I can't add this to my curseforge profile when it's such an interesting qol feature

@Eman-3600
Copy link

If you want to work on it in an actual development environment, you'll want three things:
IntelliJ IDEA
Github Desktop App
The Git plugin for IntelliJ (you should be able to find it in plugins once you open IntelliJ)

With Github Desktop, you can download your forked repository onto your computer and push changes straight to your fork. Then, open build.gradle using IntelliJ IDEA. It'll start building, and... you'll find an issue with your build. I'm not sure how to resolve it honestly.

@Eman-3600
Copy link

This pull doesn't build :(

@heyInvi
Copy link
Author

heyInvi commented Aug 3, 2022

This pull doesn't build :(

I downloaded the stuff you linked, but I'm having a lot of trouble installing/configuring the git plugin, and I feel like it's taking me longer than it reasonably should to understand most of it. what is the push/pull thing, what does building mean, and does git plugin absolutely NEED to be in my computer's c:/ drive rather than my external harddrive? I'm really sorry if this is too many questions or I should be finding tutorials, but I'm honestly just trying to update this one mod and I don't know if I'm gonna be exploring this any further, at least not anytime soon

@Eman-3600
Copy link

Well here's a tutorial on setting up a mod.
Git isn't required; it's just convenient. It lets you push changes directly from IntelliJ instead of having to go back to Github Desktop to push it from there.

@Eman-3600
Copy link

I will say though, I've taken a stab at this myself and I have absolutely know idea what's wrong, only that it won't even build the gradle.

@heyInvi
Copy link
Author

heyInvi commented Aug 3, 2022 via email

@Eman-3600
Copy link

Eman-3600 commented Aug 3, 2022

the only things I changed were version numbers for anything I thought needed to be changed, like fabric loader and API (and something called yarn mappings???), Minecraft version, and that's it the rest of the mod should be perfectly fine I haven't tested if it's working on the version it says it's for, cause it could be a problem that was already there I'm sorry I don't really know how else to help

I know, that's the confusing bit. It should have at least built the gradle. Unfortunately I just don't know enough about modding to diagnose the problem yet.

@heyInvi
Copy link
Author

heyInvi commented Aug 3, 2022

the only things I changed were version numbers for anything I thought needed to be changed, like fabric loader and API (and something called yarn mappings???), Minecraft version, and that's it the rest of the mod should be perfectly fine I haven't tested if it's working on the version it says it's for, cause it could be a problem that was already there I'm sorry I don't really know how else to help

I know, that's the confusing bit. It should have at least built the gradle. Unfortunately I just don't know enough about modding to diagnose the problem yet.

you know in retrospect I probably should've just started by asking them if they were gonna update it to 1.19. I'll try that first and come back to this in a while, once I've followed the tutorial and played around with it a bit

@Eman-3600
Copy link

lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants