Add the notion of interlocutor to Blabber #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Realized quite a few use cases for dialogues involved someone to talk to, so here goes.
At first the feature scope was :
@interlocutor
entity selector (only applicable to players)blabber:interlocutor_properties
loot conditionThe latter change however means the dialogues have to be parsed and sent whenever a player starts one. Therefore, the registry's contents would only be used clientside to provide the suggestions in commands. It seemed to me that this may be somewhat overkill, so I killed the synced registry part, and synced just the identifiers using the new configuration phase.
Having removed one reason to use Minecraft's dynamic registries, I started looking at the other ones :
However, they present some rather large downsides :
Considering the cost of an in-house data loader is rather minimal, I figured this way may be best. The lack of registry events may be an issue for future add-on development, but I figured we could add our own callbacks when the need arises.
Future considerations :
DialogueAction
(possible breaking change, though it could go to a separate interface)