Add dialogue illustrations #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pyrofab
reviewed
Feb 11, 2024
There was a problem hiding this comment.
Excellent work, looking forward to seeing it ingame myself =)
I was also thinking, would it maybe make sense to define illustrations at the top level and reference them in individual states ? That way you would avoid copying e.g. an interlocutor illustration a dozen times.
src/main/java/org/ladysnake/blabber/api/DialogueIllustrationType.java
Outdated
Show resolved
Hide resolved
src/main/java/org/ladysnake/blabber/api/DialogueIllustration.java
Outdated
Show resolved
Hide resolved
src/main/java/org/ladysnake/blabber/api/DialogueIllustration.java
Outdated
Show resolved
Hide resolved
src/main/java/org/ladysnake/blabber/api/client/BlabberDialogueScreen.java
Outdated
Show resolved
Hide resolved
src/main/java/org/ladysnake/blabber/impl/common/machine/DialogueStateMachine.java
Outdated
Show resolved
Hide resolved
src/main/java/org/ladysnake/blabber/impl/common/model/DialogueIllustrationItem.java
Outdated
Show resolved
Hide resolved
src/main/java/org/ladysnake/blabber/impl/common/model/DialogueIllustrationNbtEntity.java
Outdated
Show resolved
Hide resolved
src/main/java/org/ladysnake/blabber/impl/common/model/DialogueIllustrationNbtEntity.java
Outdated
Show resolved
Hide resolved
src/main/java/org/ladysnake/blabber/impl/common/model/DialogueIllustrationNbtEntity.java
Outdated
Show resolved
Hide resolved
src/main/java/org/ladysnake/blabber/api/DialogueIllustrationType.java
Outdated
Show resolved
Hide resolved
Pyrofab
reviewed
Feb 11, 2024
src/main/java/org/ladysnake/blabber/impl/common/model/DialogueIllustrationSelectorEntity.java
Outdated
Show resolved
Hide resolved
src/main/java/org/ladysnake/blabber/impl/common/model/DialogueIllustrationSelectorEntity.java
Outdated
Show resolved
Hide resolved
src/main/java/org/ladysnake/blabber/impl/common/model/DialogueIllustrationSelectorEntity.java
Outdated
Show resolved
Hide resolved
|
By the way could you run the |
|
Need to update your tests now |
Pyrofab
reviewed
Feb 12, 2024
src/main/java/org/ladysnake/blabber/impl/common/validation/ValidationResult.java
Outdated
Show resolved
Hide resolved
src/main/java/org/ladysnake/blabber/api/client/BlabberDialogueScreen.java
Outdated
Show resolved
Hide resolved
|
Btw when this is fully ready to be merged I'll squash all the commits, cus otherwise that's a lot of random small commits lol |
|
Also you could add a test for invalid illustrations in |
Pyrofab
reviewed
Feb 12, 2024
...ain/java/org/ladysnake/blabber/impl/common/illustrations/DialogueIllustrationCollection.java
Outdated
Show resolved
Hide resolved
...ain/java/org/ladysnake/blabber/impl/common/illustrations/DialogueIllustrationCollection.java
Outdated
Show resolved
Hide resolved
Pyrofab
reviewed
Feb 12, 2024
src/main/java/org/ladysnake/blabber/api/client/BlabberDialogueScreen.java
Outdated
Show resolved
Hide resolved
src/main/java/org/ladysnake/blabber/impl/common/DialogueScreenHandler.java
Outdated
Show resolved
Hide resolved
Pyrofab
approved these changes
Feb 12, 2024
SekoiaTree
force-pushed
the
dialogue_illustrations
branch
from
c94f7f3
to
b7cd71d
Compare
SekoiaTree
force-pushed
the
dialogue_illustrations
branch
from
b7cd71d
to
3fa68aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still need to document the illustrations that are integrated in Blabber, and I also want to add tooltips to item illustrations, but it's basically ready for review.