Fix Song detection and update Offsets #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/java/de/labystudio/spotifyapi/platform/windows/api/spotify/SpotifyProcess.java
|
This was brought up to me as concern.
It also works with russian and korean Sadly, im unable to test with another Windows Language, as that may affect it? |
PrincessAkira
changed the title
# Conflicts: # src/main/java/de/labystudio/spotifyapi/platform/windows/api/spotify/SpotifyProcess.java
PrincessAkira
commented
Sep 29, 2023
| && new MemoryPlaybackAccessor(this, address).isValid(); | ||
| }); | ||
| } | ||
|
|
||
| if (addressPlayBack == -1) { |
There was a problem hiding this comment.
Can be squashed into the line above 121 - 128
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
32-Bit is currently throwing a Nullpointer Exception with garbled TrackID
Investigating atm.
EDIT:
So its able to find the title name of the song in the 32-Bit with a 64-bit offset.
IT will also print true to the trackID of the 64-Bit offset in a 32-Bit application
Atleast, it lasted 2 weeks this time haha