Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

geodesics_improvements #127

Open
wants to merge 45 commits into
base: main
Choose a base branch
from
Open

geodesics_improvements #127

wants to merge 45 commits into from

Conversation

pehf
Copy link
Member

@pehf pehf commented May 7, 2021 •
edited

includes:

  • conditional geodesics, with corresponding optimization step
  • PC plot
  • factorized steerable pyramids
  • notebook
  • bunch of minor merge conflicts

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@codecov-commenter
Copy link

codecov-commenter commented May 7, 2021 •
edited by codecov bot

Codecov Report

Patch coverage: 28.12% and project coverage change: -2.22% ⚠️

Comparison is base (deb4bc3) 86.77% compared to head (3021dad) 84.55%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
- Coverage   86.77%   84.55%   -2.22%     
==========================================
  Files          35       36       +1     
  Lines        3349     3458     +109     
==========================================
+ Hits         2906     2924      +18     
- Misses        443      534      +91
Files Changed Coverage Δ
...rc/plenoptic/simulate/models/factorized_pyramid.py 0.00% <0.00%> (ø)
src/plenoptic/tools/data.py 70.96% <ø> (-0.24%) ⬇️
src/plenoptic/synthesize/geodesic.py 74.55% <24.65%> (-23.60%) ⬇️
src/plenoptic/synthesize/metamer.py 91.76% <100.00%> (-0.02%) ⬇️
src/plenoptic/tools/optim.py 94.44% <100.00%> (-0.56%) ⬇️
src/plenoptic/tools/signal.py 51.47% <100.00%> (+5.56%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pehf pehf mentioned this pull request May 10, 2021
Merged
pehf added 15 commits May 27, 2021 18:16
@pehf
Merge branch 'main' of https://github.com/LabForComputationalVision/p…
c541774 
…lenoptic into geodesic_improvements
@pehf
conflict resolution
c6b29e2
@pehf
a little more testing
64586ec
@pehf
fixed notebook?
3c3c5cf
@pehf
Merge branch 'main' of https://github.com/LabForComputationalVision/p…
626f310 
…lenoptic into geodesic_improvements
@pehf
require pytorch 1.8
f91604c
@pehf
Merge branch 'main' of https://github.com/LabForComputationalVision/p…
e6b9ac9 
…lenoptic into polar
@pehf
Merge branch 'polar' of https://github.com/LabForComputationalVision/…
dc41442 
…plenoptic into geodesic_improvements
@pehf
fix notebook 3 and visualize fact pyr eigdist in notebook 1
71b5f2b
@pehf
fix DATA_PATH and tuto03
18f961b
@pehf
add PCA vizualization, examples and tests
d366afe
@pehf
smaller img for quicker runtime
1e79909
@pehf
fixes display.ipynb
57eb371
@pehf
fix and test autocorr (center_crop), and cosmetics
7ec0c05
@pehf
cosmetics
72db67c
@pehf pehf marked this pull request as ready for review June 10, 2021 15:35
@billbrod billbrod self-requested a review as a code owner July 24, 2023 19:54
@billbrod
Geodesic.objective_function collapses across 2dims
02dd9e2 
only collapse across height and width, channel might be informative
@billbrod
don't hardcode color for plot_deviation_from_line
cc2ffb1
@billbrod
adds plot_pc_projections, but not sure I'll useit
c99771b
@billbrod
adds 2pixel intro to geodesic
f85f398
@billbrod
small updates to plotting
4e9fa30 
makes plots more consistent
@billbrod
starts overhaul of translation example
5132b25
@billbrod
Merge branch 'main' of github.com:LabForComputationalVision/plenoptic…
7b05b46 
… into geodesic_improvements
@billbrod
only need one metamer.requires_grad_() call
3cc8525
@billbrod
adds pytorch implementation of np.unwrap
0340013
@billbrod
geodesic can now set initial_sequence directly
60e0bdf
@billbrod
some updates to geodesicnotebook
6a4cf3d
@billbrod
remove tutorials shield (no longer using)
e1227ba
@billbrod
corrects coverage command
e3c4280
@billbrod
adds test for unwrap, fix dim=-1 when ndim=1
467fbf1
@billbrod
adds tests for setting geodesic init
b250a4a
@billbrod
fixes failing geodesic tests
c685de0
@billbrod
fix coverage command?
73d82aa
@billbrod
unwrap correctly handles negative dims, adds tests for negative dims
9f03a88
@billbrod
add --showlocals to pytest options
af70146
@billbrod
add tests for unwrap failures
3021dad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billbrod billbrod Awaiting requested review from billbrod billbrod is a code owner

At least 0 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pehf @codecov-commenter @ThomasYerxa @billbrod